fix(manager-dashboard): correctly set isPano for street projects #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gigaszi
reviewed
Jan 27, 2025
| creatorId?: number; | ||
| isPano?: boolean; | ||
| panoOnly?: boolean; | ||
| isPano?: boolean | null; |
Collaborator
There was a problem hiding this comment.
shouldnt isPano be removed here?
Collaborator
Author
There was a problem hiding this comment.
I think this needs to remain as a type check for valuesToCopy.isPano.
|
|
||
| valuesToCopy.startTimestamp = valuesToCopy.dateRange?.startDate ?? null; | ||
| valuesToCopy.endTimestamp = valuesToCopy.dateRange?.endDate ?? null; | ||
| valuesToCopy.isPano = valuesToCopy.panoOnly ? true : null; |
Collaborator
There was a problem hiding this comment.
so it can not be false. or? Is this intended?
Collaborator
Author
There was a problem hiding this comment.
This is as originally intended. The input allows a project creator to decide whether they want all images (isPano = null) or only panoramic ones (isPano = true). In case there should be a need for creating projects with only non-panoramic features, we could adapt the Manager Dashboard later accordingly.
Gigaszi
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mapillary image filter section on the new project form for projects of type Street has a checkbox input to determine whether Mapillary imagery should be filtered for 360° panoramic images or not.
Before this fix, leaving the box unchecked would result in adding a
isPanofield with the valuefalseto the project draft, which in return would mean that the python creation worker would filter available imagery for non-panoramic images.With this fix,
isPanois not added to the project draft if the checkbox is left unmarked, meaning that both panoramic and non-panoramic images are used, as was originally intended.