Skip to content

fix: Remove compiler warnings #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrispader merged 6 commits into from
Nov 4, 2025
Merged

fix: Remove compiler warnings #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8a4bec1
chore: add .ruby-version file and update version in GH workflow
chrispader Oct 9, 2025
5d293c0
fix: add `pragma once` to `logs.hpp`
chrispader Oct 9, 2025
d9993a7
fix: remove unused variables
chrispader Oct 9, 2025
1b171f7
chore: rename LOG_TAG
chrispader Oct 9, 2025
c861243
Merge branch 'main' into fix/remove-compiler-errors
chrispader Nov 4, 2025
d46f5ed
remove LOG_TAG from CMakeLists.txt
chrispader Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package/android/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ endif()
target_compile_options(
${CMAKE_PROJECT_NAME}
PRIVATE
-DLOG_TAG=\"ReactNative\"
-fexceptions
-frtti
-fstack-protector-all
Expand Down
26 changes: 14 additions & 12 deletions package/cpp/logs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,39 @@
#pragma once

#define NITRO_SQLITE_LOG_TAG "react-native-nitro-sqlite"

#ifdef ANDROID
// LOGS ANDROID
#include <android/log.h>
#define LOG_TAG "react-native-nitro-sqlite"
#define LOGV(...) __android_log_print(ANDROID_LOG_VERBOSE, LOG_TAG, __VA_ARGS__)
#define LOGD(...) __android_log_print(ANDROID_LOG_DEBUG, LOG_TAG, __VA_ARGS__)
#define LOGI(...) __android_log_print(ANDROID_LOG_INFO, LOG_TAG, __VA_ARGS__)
#define LOGW(...) __android_log_print(ANDROID_LOG_WARN, LOG_TAG, __VA_ARGS__)
#define LOGE(...) __android_log_print(ANDROID_LOG_ERROR, LOG_TAG, __VA_ARGS__)
#define LOGV(...) __android_log_print(ANDROID_LOG_VERBOSE, NITRO_SQLITE_LOG_TAG, __VA_ARGS__)
#define LOGD(...) __android_log_print(ANDROID_LOG_DEBUG, NITRO_SQLITE_LOG_TAG, __VA_ARGS__)
#define LOGI(...) __android_log_print(ANDROID_LOG_INFO, NITRO_SQLITE_LOG_TAG, __VA_ARGS__)
#define LOGW(...) __android_log_print(ANDROID_LOG_WARN, NITRO_SQLITE_LOG_TAG, __VA_ARGS__)
#define LOGE(...) __android_log_print(ANDROID_LOG_ERROR, NITRO_SQLITE_LOG_TAG, __VA_ARGS__)
#define LOGSIMPLE(...)
#else
// LOGS NO ANDROID
#include <stdio.h>
#define LOG_TAG "react-native-nitro-sqlite"
#define LOGV(...) \
printf(" "); \
printf(__VA_ARGS__); \
printf("\t - <%s> \n", LOG_TAG);
printf("\t - <%s> \n", NITRO_SQLITE_LOG_TAG);
#define LOGD(...) \
printf(" "); \
printf(__VA_ARGS__); \
printf("\t - <%s> \n", LOG_TAG);
printf("\t - <%s> \n", NITRO_SQLITE_LOG_TAG);
#define LOGI(...) \
printf(" "); \
printf(__VA_ARGS__); \
printf("\t - <%s> \n", LOG_TAG);
printf("\t - <%s> \n", NITRO_SQLITE_LOG_TAG);
#define LOGW(...) \
printf(" * Warning: "); \
printf(__VA_ARGS__); \
printf("\t - <%s> \n", LOG_TAG);
printf("\t - <%s> \n", NITRO_SQLITE_LOG_TAG);
#define LOGE(...) \
printf(" *** Error: "); \
printf(__VA_ARGS__); \
printf("\t - <%s> \n", LOG_TAG);
printf("\t - <%s> \n", NITRO_SQLITE_LOG_TAG);
#define LOGSIMPLE(...) \
printf(" "); \
printf(__VA_ARGS__);
Expand Down
2 changes: 1 addition & 1 deletion package/cpp/operations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ SQLiteOperationResult sqliteExecuteLiteral(const std::string& dbName, const std:
bool isConsuming = true;
bool isFailed = false;

int result, i, count, column_type;
int result;
std::string column_name;

while (isConsuming) {
Expand Down
Loading