Skip to content

chore: Fix React dependency versions due to runtime issue #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrispader merged 11 commits into from
Nov 4, 2025
Merged

chore: Fix React dependency versions due to runtime issue #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8a4bec1
chore: add .ruby-version file and update version in GH workflow
chrispader Oct 9, 2025
5d293c0
fix: add `pragma once` to `logs.hpp`
chrispader Oct 9, 2025
d9993a7
fix: remove unused variables
chrispader Oct 9, 2025
1b171f7
chore: rename LOG_TAG
chrispader Oct 9, 2025
c861243
Merge branch 'main' into fix/remove-compiler-errors
chrispader Nov 4, 2025
d46f5ed
remove LOG_TAG from CMakeLists.txt
chrispader Nov 4, 2025
e640a6a
chore: update packages and add back `react-test-renderer`
chrispader Nov 4, 2025
389f7b1
chore: update pods
chrispader Nov 4, 2025
86364de
chore: downgrade React because of runtime issue
chrispader Nov 4, 2025
3060588
fix: ios CI build
chrispader Nov 4, 2025
1effac3
chore: update podfiles cache key in CI
chrispader Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ jobs:
with:
ruby-version: 3.3.0
bundler-cache: true
working-directory: example/ios
working-directory: example

- name: Restore Pods cache
uses: actions/cache@v4
with:
path: example/ios/Pods
key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock', '**/Gemfile.lock') }}
key: pods-${{ runner.os }}-${{ hashFiles('**/Podfile.lock', '**/Gemfile.lock') }}
restore-keys: |
${{ runner.os }}-pods-
pods-${{ runner.os }}

- name: Install Pods
working-directory: example/ios
Expand Down
62 changes: 50 additions & 12 deletions bun.lock
View file
Open in desktop

Large diffs are not rendered by default.

122 changes: 61 additions & 61 deletions example/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2778,77 +2778,77 @@ SPEC CHECKSUMS:
fmt: a40bb5bd0294ea969aaaba240a927bd33d878cdd
glog: 5683914934d5b6e4240e497e0f4a3b42d1854183
hermes-engine: 273e30e7fb618279934b0b95ffab60ecedb7acf5
NitroModules: 80f9806fec600004e727f84d647105c331d9567e
RCT-Folly: 59ec0ac1f2f39672a0c6e6cecdd39383b764646f
NitroModules: 18d9127f80848a1d12ed4bf59d14a6d816a720d8
RCT-Folly: 846fda9475e61ec7bcbf8a3fe81edfcaeb090669
RCTDeprecation: f17e2ebc07876ca9ab8eb6e4b0a4e4647497ae3a
RCTRequired: e2c574c1b45231f7efb0834936bd609d75072b63
RCTTypeSafety: c693294e3993056955c3010eb1ebc574f1fcded6
React: aeece948ccf155182ea86a2395786ed31cf21c61
React-callinvoker: 05ad789505922d68c06cde1c8060e734df9fe182
React-Core: 727a48090292599bda380e05c9f1318e21578837
React-CoreModules: b26015efc6c222479e6939c0d7497cfac08a1a24
React-cxxreact: 1e6640d1e9a36744c4ce861bf2a5c8cee4abe9cf
React-Core: 956ac86b4d9b0c0fd9a14b9cc533aa297bb501c0
React-CoreModules: 3a8d39778cf9eeca40e419814e875da1a8e29855
React-cxxreact: db275765e1eb08f038599fb44114cf57ee0d18cd
React-debug: c8356d908286b1dc4cf90cd0977227dd61b7b1eb
React-defaultsnativemodule: fb977ad0f1b0143bc347502bfca013ce04bc5ac2
React-domnativemodule: 69973dd5636c2312c22e6ab0d1482d1ae9237b10
React-Fabric: 247d7d8e86086d740b300b3235a3030abac014f8
React-FabricComponents: a709654e26e6df31326b76cb577c78736072035f
React-FabricImage: 3dd86ca127bcfbd4f4f6de94b54a02d6bfdceb66
React-featureflags: 4e884750babddea1393607c707aa69cddafe331d
React-featureflagsnativemodule: 6b0f4a084b329f8436027b5e41306a1b0a94853c
React-graphics: 8e534c09ed42f63cb851824cdb8603ba7afee33b
React-hermes: 5c2453ae5a3c2f34a15eaefb229375998e365810
React-idlecallbacksnativemodule: ed3f3aa75bafeb8399fe3f8d1b400f5cc1411e9f
React-ImageManager: f722c84960b93cfabbc2a3350c8b41a896c67b94
React-jserrorhandler: c48e4fb8420929551233ea98704fe2af45241b26
React-jsi: 389d2e9fe9bd935bdaff38e0d72eb2cad1ad3071
React-jsiexecutor: 0821fa7695e1a6a868aa47a40a0fc5036552128b
React-jsinspector: d906ba52a2ee5904842bfde1d1e048a0903ec276
React-jsinspectorcdp: 90df4e6b4ddb0f3219b9bc30d8337c036b104945
React-jsinspectornetwork: c270ce162ca81135bd473f8c7c10c97077d2ee55
React-jsinspectortracing: 60f8d7e1298a6e30bcc0696500a32b94cfb85602
React-jsitooling: 923d6da787b15bec2560985d19299638209c356e
React-jsitracing: 1dce29ae7b654a8399fb8a12ad7b0bc364e631c8
React-logger: fceaaedb9c715923a1900af68a7534e9b3a601a1
React-Mapbuffer: 60a42c90f1db2c852d5e06577f3d3d5d3233d45b
React-microtasksnativemodule: 044e6549d565f0a5f23b01cf3ed745541cb980e0
react-native-safe-area-context: fea29ae0275beaa22f72d0a8be1eb0ab09c3feae
React-NativeModulesApple: a4af348fce12730a7bc424559e8207b35e6ac046
React-defaultsnativemodule: df1a41d072194c96d0077dd30ee8d5d452397f26
React-domnativemodule: 8abd63d26685a5c1c88c8ccc902876dc9c0e2d6f
React-Fabric: 1dea7e164181d7d688cfbd70a6e5f026e2df6bf5
React-FabricComponents: 2a6f81481fa240a9239536402d72823f9d642925
React-FabricImage: 513940cfd43193d3befb45dba9911f936bd74df7
React-featureflags: bc1d980ff8356b931cd87c16700a39aaede1ed5a
React-featureflagsnativemodule: 4f7beedf0c241c44dcffc51e52a6178b5e0d541d
React-graphics: 69311413b44b6d228dbc705d8ce57ad0a4d55daf
React-hermes: b454b9352bc26e638704d103009f659a125b86d3
React-idlecallbacksnativemodule: d15d469a152b7677d184a9538fae0744692e4575
React-ImageManager: cce591e16cc6fa63ad5d45de012b4ddf31fd21e9
React-jserrorhandler: 05fb248a535148a7eec94c786bd0e9e1413c6b3a
React-jsi: 7aa265cf8372d8385ccc7935729e76d27e694dfe
React-jsiexecutor: 8dd53bebfb3bc12f0541282aa4c858a433914e37
React-jsinspector: 0f62d1ffa7242033a1106f0af9f83ec12a381401
React-jsinspectorcdp: 5ae22d48dcf03812cd4f8c4a6fd7c7204cd8789d
React-jsinspectornetwork: 9052eb6bbd876bfdafa1605874dd848511236844
React-jsinspectortracing: 6d89a5caab7b86947607cf654fc94cf1c31f8330
React-jsitooling: ecbd81f751b79ba748d4d0d54445da1b53e363fd
React-jsitracing: 8068734240da604902fead29287dc21b820bc7d3
React-logger: 500f2fa5697d224e63c33d913c8a4765319e19bf
React-Mapbuffer: 4c50cf6af44286015a20a5995d5321f625c93459
React-microtasksnativemodule: a84b9331106616ab1fa36de9ae555718d4bbdcf5
react-native-safe-area-context: 0a3b034bb63a5b684dd2f5fffd3c90ef6ed41ee8
React-NativeModulesApple: efd0906463c79d9b86197dbcf0d58358dff8c5ed
React-oscompat: 95875e81f5d4b3c7b2c888d5bd2c9d83450d8bdb
React-perflogger: d5b5677902d23a6611b700601634271b29356ac6
React-performancecdpmetrics: e702a75f821bab0d8cfbbf19b69685d016d90976
React-performancetimeline: 2f4e857009d66981234a89295a9dc1e600ab599e
React-perflogger: 2e229bf33e42c094fd64516d89ec1187a2b79b5b
React-performancecdpmetrics: fd9bbc52960c6aa008fdae263849eb14411ae13e
React-performancetimeline: 16eaea3f8be5d42eb3bf8a261d87df2fe7e6e111
React-RCTActionSheet: 2399bb6cc8adaef2e5850878102fea2ad1788a0e
React-RCTAnimation: a7e596bacb4706501556dcaaa8cd4062c8858d40
React-RCTAppDelegate: 40a84753dc9d7c2535b9e748c30bae50d39c6580
React-RCTBlob: e3264ae55b1b856db8e654bb7066b8343e030a67
React-RCTFabric: 72192612662f30c0341b5af0ea1aa1ba94363af9
React-RCTFBReactNativeSpec: 7bc14361102434704219c6121bed27e5d60e85fa
React-RCTImage: fb1d64345bb2e26af63e06e1ffc2cf99d572e2e1
React-RCTLinking: cb91127e75ee2d081f1abffd08d63db185805439
React-RCTNetwork: f38a98b030faedf2dc5c9061d6ed0074b3513c72
React-RCTRuntime: 1fcc791cfc9a2db3372f1c0b447110d55a0ac509
React-RCTSettings: 00cc62efb88ec24608cefaa7db4ad04461a511b4
React-RCTText: 2b963648a99f49875349bd18c0dd7f2a4acf50c1
React-RCTVibration: 16e31c7f90f13bec10385aeb5cc61e8a45e591e4
React-RCTAnimation: d1deb6946e83e22a795a7d0148b94faad8851644
React-RCTAppDelegate: 10b35d5cec3f8653f6de843ae800b3ba8050b801
React-RCTBlob: 85150378edc42862d7c13ff2502693f32b174f91
React-RCTFabric: f57a14a48756480a7c96670d633cb39692eed453
React-RCTFBReactNativeSpec: 725c3bb08b2f86741df136455960f2b58dd8f6e4
React-RCTImage: bb6cbdc22698b3afc8eb8d81ef03ee840d24c6f6
React-RCTLinking: e8b006d101c45651925de3e82189f03449eedfe7
React-RCTNetwork: 7999731af05ec8f591cbc6ad4e29d79e209c581a
React-RCTRuntime: cdbbadadafcad5836fb0616073d7011c39c30ffd
React-RCTSettings: 839f334abb92e917bc24322036081ffe15c84086
React-RCTText: 272f60e9a5dbfd14c348c85881ee7d5c7749a67c
React-RCTVibration: 1ffa30a21e2227be3afe28d657ac8e6616c91bae
React-rendererconsistency: a51dcbe4b3c1159413cfdb85abace6a5c871a4b3
React-renderercss: b662684b10b2db811170d4cd3fc8f596a610e1d1
React-rendererdebug: bdac9bee1c2a4652950d69fe1473758df1d74386
React-RuntimeApple: 002693758f983d7525c78cbfe76d861c785dff9c
React-RuntimeCore: b7209809043765a222ac94a8e003151a1fbc7191
React-runtimeexecutor: 116dc5eda382665289a9cae49f5d6ce6674aeb7f
React-RuntimeHermes: 66912cd152c427893139ef823b7262d247fbd126
React-runtimescheduler: 8b06c661ab199147fc2d1b2e5b187b00fe128ce8
React-timing: 39719c01339255ec6243ca5b80b9b54e9698f853
React-utils: 47008b6e3d45ea592b265ed012cb5889318eb07b
React-webperformancenativemodule: de8eef3927b27f35d24dfa04563d44a58c3bbf2f
ReactAppDependencyProvider: cc2795efe30a023c3a505676b9c748b664b9c0a1
ReactCodegen: 4fe46e8d9f3f162c31f99333df3cdf3b93f2aa89
ReactCommon: 6087cb6198592a8dc52a37c0f3761644fead5c88
RNNitroSQLite: d5cf8c550c51015e1ecc93ff6e7509187c6c1c9e
RNScreens: de996b48c82245c0b68c677da3334c2061e2a951
React-renderercss: 5fdc31a529021337e7eac6f1e9bf4410947b877e
React-rendererdebug: 8427d2e5d1b7e39971c9c59e55bbfcb7884a942f
React-RuntimeApple: 9ba3723a539ed1701b8ba08dc317f1255c269a37
React-RuntimeCore: 61b10d50472e29cd1ec98aba797d0d8d4f325283
React-runtimeexecutor: 8e5135a09dcb012a15a025dc514361c927ea5db9
React-RuntimeHermes: f06c7288967d0209fc075e5eabd5e851580047e9
React-runtimescheduler: bd92275b3a847c71d10210ae89a8e04dba076630
React-timing: 91f11a6537770b698eb8152e4669012992710b27
React-utils: f06ff240e06e2bd4b34e48f1b34cac00866e8979
React-webperformancenativemodule: b3398f8175fa96d992c071b1fa59bd6f9646b840
ReactAppDependencyProvider: a45ef34bb22dc1c9b2ac1f74167d9a28af961176
ReactCodegen: 09d235f636e22db7c2fbb24a59a56aa579591226
ReactCommon: 801eff8cb9c940c04d3a89ce399c343ee3eff654
RNNitroSQLite: ca40d7c6e2fe61674187320734b542a56534f65f
RNScreens: 98771ad898d1c0528fc8139606bbacf5a2e9d237
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
Yoga: 46ff53afcbeda2bae19c85b65e17487c3e3984dd
Yoga: 526f25666395d30c297d53154398ffd249eaf9e1

PODFILE CHECKSUM: efa901d259f2a40103bc359243a7632881296bf1

Expand Down
14 changes: 8 additions & 6 deletions example/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,18 @@
},
"dependencies": {
"@craftzdog/react-native-buffer": "^6.0.5",
"@react-navigation/native": "^7.0.14",
"@react-navigation/native-stack": "^7.2.0",
"@react-navigation/native": "^7.1.19",
"@react-navigation/native-stack": "^7.6.2",
"chai": "^4.3.7",
"chance": "^1.1.9",
"events": "^3.3.0",
"expo-status-bar": "^1.12.1",
"react": "19.2.0",
"react": "19.1.1",
"react-native": "0.82.1",
"react-native-nitro-modules": "0.27.2",
"react-native-nitro-sqlite": "9.1.11",
"react-native-safe-area-context": "^5.5.2",
"react-native-screens": "^4.9.1",
"react-native-screens": "^4.18.0",
"reflect-metadata": "^0.1.13",
"stream-browserify": "^3.0.0",
"typeorm": "0.3.20",
Expand All @@ -47,8 +47,10 @@
"@types/chance": "^1.1.3",
"@types/mocha": "^10.0.1",
"@types/node": "^22.7.4",
"@types/react": "^19.2.0",
"@types/react": "^19.1.1",
"@types/react-test-renderer": "^19.1.0",
"mocha": "^10.1.0",
"postinstall-postinstall": "^2.1.0"
"postinstall-postinstall": "^2.1.0",
"react-test-renderer": "19.1.1"
}
}
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
},
"dependencies": {
"patch-package": "^8.0.0",
"react": "19.2.0",
"react": "19.1.1",
"react-native": "0.82.1",
"react-native-nitro-modules": "0.27.2"
},
Expand All @@ -55,7 +55,7 @@
"@tsconfig/react-native": "^2.0.2",
"@types/eslint__js": "^8.42.3",
"@types/jest": "^29.5.13",
"@types/react": "^19.2.0",
"@types/react": "^19.1.1",
"babel-plugin-module-resolver": "^5.0.2",
"babel-plugin-transform-typescript-metadata": "^0.3.2",
"eslint": "8.57.1",
Expand Down
1 change: 0 additions & 1 deletion package/android/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ endif()
target_compile_options(
${CMAKE_PROJECT_NAME}
PRIVATE
-DLOG_TAG=\"ReactNative\"
-fexceptions
-frtti
-fstack-protector-all
Expand Down
26 changes: 14 additions & 12 deletions package/cpp/logs.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,39 @@
#pragma once

#define NITRO_SQLITE_LOG_TAG "react-native-nitro-sqlite"

#ifdef ANDROID
// LOGS ANDROID
#include <android/log.h>
#define LOG_TAG "react-native-nitro-sqlite"
#define LOGV(...) __android_log_print(ANDROID_LOG_VERBOSE, LOG_TAG, __VA_ARGS__)
#define LOGD(...) __android_log_print(ANDROID_LOG_DEBUG, LOG_TAG, __VA_ARGS__)
#define LOGI(...) __android_log_print(ANDROID_LOG_INFO, LOG_TAG, __VA_ARGS__)
#define LOGW(...) __android_log_print(ANDROID_LOG_WARN, LOG_TAG, __VA_ARGS__)
#define LOGE(...) __android_log_print(ANDROID_LOG_ERROR, LOG_TAG, __VA_ARGS__)
#define LOGV(...) __android_log_print(ANDROID_LOG_VERBOSE, NITRO_SQLITE_LOG_TAG, __VA_ARGS__)
#define LOGD(...) __android_log_print(ANDROID_LOG_DEBUG, NITRO_SQLITE_LOG_TAG, __VA_ARGS__)
#define LOGI(...) __android_log_print(ANDROID_LOG_INFO, NITRO_SQLITE_LOG_TAG, __VA_ARGS__)
#define LOGW(...) __android_log_print(ANDROID_LOG_WARN, NITRO_SQLITE_LOG_TAG, __VA_ARGS__)
#define LOGE(...) __android_log_print(ANDROID_LOG_ERROR, NITRO_SQLITE_LOG_TAG, __VA_ARGS__)
#define LOGSIMPLE(...)
#else
// LOGS NO ANDROID
#include <stdio.h>
#define LOG_TAG "react-native-nitro-sqlite"
#define LOGV(...) \
printf(" "); \
printf(__VA_ARGS__); \
printf("\t - <%s> \n", LOG_TAG);
printf("\t - <%s> \n", NITRO_SQLITE_LOG_TAG);
#define LOGD(...) \
printf(" "); \
printf(__VA_ARGS__); \
printf("\t - <%s> \n", LOG_TAG);
printf("\t - <%s> \n", NITRO_SQLITE_LOG_TAG);
#define LOGI(...) \
printf(" "); \
printf(__VA_ARGS__); \
printf("\t - <%s> \n", LOG_TAG);
printf("\t - <%s> \n", NITRO_SQLITE_LOG_TAG);
#define LOGW(...) \
printf(" * Warning: "); \
printf(__VA_ARGS__); \
printf("\t - <%s> \n", LOG_TAG);
printf("\t - <%s> \n", NITRO_SQLITE_LOG_TAG);
#define LOGE(...) \
printf(" *** Error: "); \
printf(__VA_ARGS__); \
printf("\t - <%s> \n", LOG_TAG);
printf("\t - <%s> \n", NITRO_SQLITE_LOG_TAG);
#define LOGSIMPLE(...) \
printf(" "); \
printf(__VA_ARGS__);
Expand Down
2 changes: 1 addition & 1 deletion package/cpp/operations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ SQLiteOperationResult sqliteExecuteLiteral(const std::string& dbName, const std:
bool isConsuming = true;
bool isFailed = false;

int result, i, count, column_type;
int result;
std::string column_name;

while (isConsuming) {
Expand Down
2 changes: 1 addition & 1 deletion package/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"devDependencies": {
"jest": "^30.2.0",
"nitro-codegen": "0.27.2",
"react": "19.2.0",
"react": "19.1.1",
"react-native": "0.82.1",
"react-native-builder-bob": "^0.31.0",
"react-native-nitro-modules": "0.27.2"
Expand Down
Loading