Skip to content

Conversation

@aimanecouissi
Copy link
Contributor

This change disables admin password expiration in the development environment by setting the password lifetime to 0, so admin users are not forced to regularly change their passwords while developing.

It also moves bin/magento setup:upgrade to run immediately after sampledata:deploy. Running the upgrade only at the end cause sample data to not be properly applied and its modules appear as disabled. Running it right after deploying sample data ensures all sample data modules are correctly registered before continuing with the rest of the setup.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 12, 2025
@what-the-diff
Copy link

what-the-diff bot commented Dec 12, 2025

PR Summary

  • Addition of a New Post-Deployment Command
    The recent change includes a command that will help run a setup upgrade for Magento after the sample data has been deployed. This is an automated step enhancing the post-deployment process.

  • Admin Password Lifetime Update
    A newly added command will disable the password lifetime in the admin security settings by setting its value to zero. This way, it eliminates the need for periodic password changes, providing smoother admin access management.

  • Enhanced Comments for Better Clarity
    The comments in the code were tidied up for better understanding of the procedures at hand. This clarifies the process, making it much more readable and easier to follow.

@dosubot dosubot bot added the feature label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants