no message

Author: martin-georgiev

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonbEachTest.php

@@ -17,33 +17,40 @@ protected function getStringFunctions(): array
     }
 
     #[Test]
-    public function jsonb_each(): void
+    public function extracts_key_value_pairs_from_standard_json_object(): void
     {
         $dql = 'SELECT JSONB_EACH(t.object1) as result 
                 FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t 
                 WHERE t.id = 1';
         $result = $this->executeDqlQuery($dql);
         $this->assertCount(4, $result);
+
+        $extractedKeys = [];
         foreach ($result as $row) {
             $this->assertIsArray($row);
             $this->assertArrayHasKey('result', $row);
             $this->assertIsString($row['result']);
+
             $decoded = \json_decode($row['result'], true);
             if (\is_array($decoded) && isset($decoded['key'], $decoded['value'])) {
                 $key = $decoded['key'];
-                $value = $decoded['value'];
             } else {
                 $parts = \explode(':', \trim($row['result'], '{}"'));
                 $key = $parts[0] ?? null;
-                $value = $parts[1] ?? null;
             }
 
             $this->assertNotNull($key);
+            $extractedKeys[] = $key;
+        }
+
+        $expectedKeys = ['name', 'age', 'address', 'tags'];
+        foreach ($expectedKeys as $expectedKey) {
+            $this->assertContains($expectedKey, $extractedKeys, \sprintf("Expected key '%s' should be extracted", $expectedKey));
         }
     }
 
     #[Test]
-    public function jsonb_each_with_empty_object(): void
+    public function returns_empty_result_for_empty_object(): void
     {
         $dql = 'SELECT JSONB_EACH(t.object1) as result 
                 FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t 
@@ -53,32 +60,59 @@ public function jsonb_each_with_empty_object(): void
     }
 
     #[Test]
-    public function jsonb_each_with_different_object(): void
+    public function extracts_key_value_pairs_from_alternative_json_object(): void
     {
         $dql = 'SELECT JSONB_EACH(t.object1) as result 
                 FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t 
                 WHERE t.id = 2';
         $result = $this->executeDqlQuery($dql);
         $this->assertCount(4, $result);
+
+        foreach ($result as $row) {
+            $this->assertIsArray($row);
+            $this->assertArrayHasKey('result', $row);
+            $this->assertIsString($row['result']);
+
+            $decoded = \json_decode($row['result'], true);
+            $this->assertNotNull($decoded, 'Result should be valid JSON');
+        }
     }
 
     #[Test]
-    public function jsonb_each_with_nulls(): void
+    public function extracts_key_value_pairs_when_json_contains_null_values(): void
     {
         $dql = 'SELECT JSONB_EACH(t.object1) as result 
                 FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t 
                 WHERE t.id = 5';
         $result = $this->executeDqlQuery($dql);
         $this->assertCount(4, $result);
+
+        foreach ($result as $row) {
+            $this->assertIsArray($row);
+            $this->assertArrayHasKey('result', $row);
+            $this->assertIsString($row['result']);
+
+            $decoded = \json_decode($row['result'], true);
+            $this->assertNotNull($decoded, 'Result should be valid JSON even with null values');
+        }
     }
 
     #[Test]
-    public function jsonb_each_with_empty_tags_array(): void
+    public function extracts_key_value_pairs_when_json_contains_empty_array(): void
     {
         $dql = 'SELECT JSONB_EACH(t.object1) as result 
                 FROM Fixtures\MartinGeorgiev\Doctrine\Entity\ContainsJsons t 
                 WHERE t.id = 3';
         $result = $this->executeDqlQuery($dql);
         $this->assertCount(4, $result);
+
+        foreach ($result as $row) {
+            $this->assertIsArray($row);
+            $this->assertArrayHasKey('result', $row);
+            $this->assertIsString($row['result']);
+
+            $decoded = \json_decode($row['result'], true);
+            $this->assertNotNull($decoded, 'Result should be valid JSON even with empty arrays');
+        }
     }
 }

tests/Integration/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/JsonbObjectKeysTest.php

@@ -24,14 +24,14 @@ public function extracts_object_keys_from_jsonb(): void
                 WHERE t.id = 1';
         $result = $this->executeDqlQuery($dql);
         $this->assertIsString($result[0]['result']);
-        
+
         $keys = $this->transformPostgresArray($result[0]['result']);
         $this->assertIsArray($keys);
         $this->assertCount(4, $keys);
-        
+
         $expectedKeys = ['name', 'age', 'address', 'tags'];
         foreach ($expectedKeys as $expectedKey) {
-            $this->assertContains($expectedKey, $keys, "Expected key '{$expectedKey}' should be present in the extracted keys");
+            $this->assertContains($expectedKey, $keys, \sprintf("Expected key '%s' should be present in the extracted keys", $expectedKey));
         }
     }
 }