Skip to content

Conversation

@janklan
Copy link
Contributor

@janklan janklan commented Dec 13, 2025

Kudos for #486. I suppose it would make sense to use those new constants in the docs as well.

Summary by CodeRabbit

  • Documentation
    • Updated Symfony integration guide with improved PostgreSQL type mapping configuration for array, JSON, network, spatial, range, and hierarchical types.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 13, 2025

Walkthrough

Documentation update replacing static YAML type mappings for PostgreSQL types (array, JSON, network, spatial, range, hierarchical) with dynamic PHP constant references in the Symfony integration guide. Mapping keys remain unchanged; values transition from literal strings to constant-based declarations.

Changes

Cohort / File(s) Change Summary
Symfony Integration Documentation
docs/INTEGRATING-WITH-SYMFONY.md
Updates PostgreSQL type mappings from static string values to PHP constant references using !php/const syntax for array, JSON, network, spatial, range, and hierarchical types

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify that all PHP constant references are correctly formed and match the actual constant names in MartinGeorgiev\Doctrine\DBAL\Type
  • Confirm consistency in constant naming convention across all type groups
  • Check that no mapping keys were inadvertently altered during the conversion

Possibly related PRs

  • PR #486: Introduces new MartinGeorgiev\Doctrine\DBAL\Type constants that are now referenced in this documentation update
  • PR #438: Also modifies Symfony integration docs and PostgreSQL type mappings, providing context for related type mapping changes

Poem

🐰 Constants now dance where strings once lay,
YAML maps in a cleaner way!
No more quotes, just names so bright,
PHP constants shining light! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately reflects the main change: updating documentation examples to use new class constants instead of static string mappings for PostgreSQL type configurations.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

Coverage Status

coverage: 95.636%. first build
when pulling aac4922 on janklan:docs-mapping-constants
into 5ff9084 on martin-georgiev:main.

@janklan janklan changed the title (docs) Use new class contants in configuration examples docs: Use new class contants in configuration examples Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants