-
Notifications
You must be signed in to change notification settings - Fork 52
Reducing complexity of implementation in order to be able to add Atlas text search token based pagination #1046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tsmathis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really much to say on my end, I am be curious though about the performance/execution time of this implementation vs. the parallel approach.
mp_api/client/core/client.py
Outdated
| r -= 1 | ||
| except MPRestError as e: | ||
| # If we get 422 or 414 error, or 0 results for comma-separated params, split into batches | ||
| if "422" in str(e) or "414" in str(e) or "Got 0 results" in str(e): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any(trace in str(e) for trace in ("422","414","Got 0 results"))There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed with 18b0b79
77913b3 to
28e74e1
Compare
…d flatten once with chain.from_iterable
|
@esoteric-ephemera @tsmathis I've addressed all outstanding comments. Ready for re-review. |
|
Nothing else to add from my end |
…ion with append + chain.from_iterable
|
Summary
Major changes: