Angular change detection compatibility #1079
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove all not used imports
+ attach component view to application (to allow for change detection) ~ trigger change detection by markForCheck instead of forcing with detectChanges
~ use 'update' method for initial parameter setting (instead of identical implementation) ~ reduce nesting of 'update' method ~ missing import
- remove not required zone mock ~ hide expected test error ~ fix TestComponent properties do not exist on component instance ~ check for rendering with correct values in tests ~ trigger regular angular update cycle in tests + add method for accessing created component from renderer + add OnPush component test
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9352e51:
|
Author
|
PR is ready to merge @mathuo feel free to ask for any assistance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created (angular) components are not part of the change detection cycle. This require the component to manually trigger change detection - and makes most components incompatible.
This PR ensure that created (angular) components are part of the regular angular change detection cycle.
Changes: