Skip to content

Use https in ImgurPage resolution #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zpmorgan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use https in ImgurPage resolution #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83b0899
Use https in ImgurPage resolution
zpmorgan Oct 2, 2017
e4a7d3d
https for ImgurPage tests
zpmorgan Oct 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/ImgurPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
*/

var VALID_URL = /http(s*):\/\/(i\.|m\.)*imgur.com\/(gallery\/){0,1}(.*)/;
var OUT_TPL = 'http://i.imgur.com/{{id}}.jpg'; //@FIXME : image can be gif or png
var OUT_TPL = 'https://i.imgur.com/{{id}}.jpg'; //@FIXME : image can be gif or png

function ImgurPage() {
}
Expand Down
8 changes: 4 additions & 4 deletions tests/node/spec/ImgurPageSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe("Imgur : imgur page", function() {
ImgurPage.resolve("http://imgur.com/kGKMw", function( res ){
result = res;
});
expect(result).toBe("http://i.imgur.com/kGKMw.jpg");
expect(result).toBe("https://i.imgur.com/kGKMw.jpg");
});
});

Expand All @@ -27,7 +27,7 @@ describe("Imgur : imgur mobile page", function() {
ImgurPage.resolve("http://m.imgur.com/kGKMw", function( res ){
result = res;
});
expect(result).toBe("http://i.imgur.com/kGKMw.jpg");
expect(result).toBe("https://i.imgur.com/kGKMw.jpg");
});
});

Expand All @@ -37,7 +37,7 @@ describe("Imgur : imgur https page", function() {
ImgurPage.resolve("https://imgur.com/kGKMw", function( res ){
result = res;
});
expect(result).toBe("http://i.imgur.com/kGKMw.jpg");
expect(result).toBe("https://i.imgur.com/kGKMw.jpg");
});
});

Expand All @@ -47,6 +47,6 @@ describe("Imgur : imgur page in gallery", function() {
ImgurPage.resolve("http://imgur.com/gallery/PYdu6W7", function( res ){
result = res;
});
expect(result).toBe("http://i.imgur.com/PYdu6W7.jpg");
expect(result).toBe("https://i.imgur.com/PYdu6W7.jpg");
});
});