Skip to content

Conversation

@mungojam
Copy link
Contributor

@mungojam mungojam commented May 1, 2025

Issue #, if available: n/a

Description of changes:

Adds dotnet9 aot to the benchmarks. Created from #1626

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@maxday
Copy link
Owner

maxday commented May 3, 2025

Awesome! Thank you @mungojam your contribution!
Just a quick question: I'm not sure about the logic around the FROM in your Dockerfile. If I understand correctly:

ARG IMAGE_TAG
FROM $IMAGE_TAG/amazonlinux:2023 AS builder

will resolve for instance as amd64/amazonlinux:2023 which does not seem to exist?

Also can you :

  1. chmod u+x the build.sh file
  2. update Readme to include this
  3. update the .github/dependabot.yml

(I need to do a better job on documenting how to add a new permutation, sorry about that)

Thanks!

@mungojam
Copy link
Contributor Author

mungojam commented May 3, 2025

Tbh I just copied the original PR, but should be able to make it all consistent with other ones and do those changes later.

Your benchmarks were featured in a great talk at the aws London summit by the way 🙂

@maxday
Copy link
Owner

maxday commented May 3, 2025

oh sweet! Was it recorded/do you have a link or the talk name? Thanks

@maxday maxday mentioned this pull request May 3, 2025
@mungojam
Copy link
Contributor Author

mungojam commented May 3, 2025

Here is a link, scroll to the bottom, but it wasn't recorded as far as I know

'The Joy of Serverless .net?'

@mungojam
Copy link
Contributor Author

mungojam commented May 4, 2025

@maxday I believe it's sorted now. However on the docker point I haven't done anything because the new Dockerfile is identical to the one in the .net 8 AOT version, so it feels like it should work just the same:

https://github.com/maxday/lambda-perf/blob/main/s3-uploader/runtimes/dotnet8_aot_on_provided_al2023/Dockerfile

@maxday
Copy link
Owner

maxday commented May 5, 2025

Thank you so much!
Yeah it appears that the image named docker.io/arm64v8/amazonlinux:2023 actually exisits! I didn't know about that!

@maxday maxday self-requested a review May 5, 2025 09:22
@maxday maxday merged commit 1b4aeb9 into maxday:main May 5, 2025
@maxday
Copy link
Owner

maxday commented May 5, 2025

it will be live on the tool from tomorrow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants