Remove temp file creation for tests#249
Merged
oschwald merged 1 commit intomaxmind:mainfrom May 9, 2025
Merged
Conversation
oschwald
requested changes
May 8, 2025
Member
oschwald
left a comment
oschwald
left a comment
There was a problem hiding this comment.
Thanks! This is a good cleanup. I don't know the details on the Java 6 comment, but I do know the Decoder API has also changed since the comment was written 12 years ago.
I had one comment.
oschwald
reviewed
May 8, 2025
marschall
force-pushed
the
remove-temp-file
branch
from
985af67 to
c4634bc
Compare
oschwald
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the creation of temp files in tests.
Decoderdepends onByteBufferso we can use an on-heap buffer. The comment talks about Java 6 compatibility but the code depends on Java 11.