Skip to content

Update Gemfile.lock during release #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oschwald merged 3 commits into from
Jan 20, 2026
+13 −0
Merged

Update Gemfile.lock during release #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50b2bf2
Update Gemfile.lock during release
horgh Jan 19, 2026
6ed9204
Use frozen mode for bundle install in CI
horgh Jan 19, 2026
ca6c1e8
Add java platform to Gemfile.lock for JRuby support
horgh Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ jobs:
ruby-version: ruby

- run: bundle install
env:
BUNDLE_FROZEN: true

# zizmor complains that 'v1' is a ref that can be provided by both the branch and tag namespaces.
# specify that we want the v1 branch.
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,6 @@ jobs:
ruby-version: 3.4

- run: bundle install
env:
BUNDLE_FROZEN: true
- run: bundle exec rake -t rubocop
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,6 @@ jobs:
ruby-version: ${{ matrix.version }}

- run: bundle install
env:
BUNDLE_FROZEN: true
- run: bundle exec rake -t test
3 changes: 3 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ GEM
specs:
ast (2.4.3)
json (2.18.0)
json (2.18.0-java)
language_server-protocol (3.17.0.5)
lint_roller (1.1.0)
minitest (6.0.1)
Expand All @@ -18,6 +19,7 @@ GEM
racc
prism (1.7.0)
racc (1.8.1)
racc (1.8.1-java)
rainbow (3.1.1)
rake (13.3.1)
regexp_parser (2.11.3)
Expand Down Expand Up @@ -56,6 +58,7 @@ GEM
unicode-emoji (4.2.0)

PLATFORMS
java
ruby
x86_64-linux

Expand Down
4 changes: 4 additions & 0 deletions dev-bin/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ fi

check_command perl
check_command rake
check_command bundle

# Check that we're not on the main branch
current_branch=$(git branch --show-current)
Expand Down Expand Up @@ -84,6 +85,9 @@ fi

perl -pi -e "s/(?<=s.version\s{,20}=\s{,20}\').+?(?=\')/$version/g" maxmind-db.gemspec

# Update version in Gemfile.lock.
bundle install
Copy link

@gemini-code-assist gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using bundle install can update all dependencies in Gemfile.lock if newer versions are available, not just the maxmind-db gem. This could unintentionally bundle unrelated dependency updates into the release commit.

To make the update more targeted, consider using bundle update maxmind-db. This will only update the maxmind-db gem and its dependencies if necessary, keeping the release commit focused on the version change.

Suggested change
bundle install
bundle update maxmind-db


echo $"Test results:"

rake
Expand Down