Skip to content

Conversation

@oschwald
Copy link
Member

@oschwald oschwald commented Jan 8, 2026

Summary

  • Update Gradle dependency configuration from deprecated compile to implementation
  • Add groovy syntax highlighting to Gradle code block
  • Fix various typos and grammatical errors in README.md
  • Standardize heading style to use trailing ## consistently
  • Fix incorrect TransactionReport.Builder examples (constructor only takes Tag, IP address is set via builder method)
  • Document that WebServiceClient is thread-safe and should be reused for connection pooling
  • Improve sentence structure for API method descriptions

Fixes ENG-3756

Test plan

  • Verify README renders correctly on GitHub
  • Confirm Gradle instructions work with modern Gradle versions
  • Verify code examples match actual API

🤖 Generated with Claude Code

oschwald and others added 4 commits January 8, 2026 13:26
The `compile` configuration was deprecated in Gradle 3.4 and removed
in Gradle 7.0. The modern `implementation` configuration should be
used instead.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add missing article "the" before method names
- Fix missing space after hyphen in HttpException description
- Fix typo "with" → "will" in Report Transactions section
- Fix grammatically broken sentence about required arguments
- Fix typo "BanK" → "Bank" in example code
- Standardize heading style to use trailing ## consistently

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The constructor only takes Tag, not both InetAddress and Tag.
The IP address must be set via the ipAddress() builder method.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add groovy syntax highlighting to Gradle code block
- Document that WebServiceClient is thread-safe and should be reused
- Fix trailing whitespace and punctuation
- Improve sentence structure for API method descriptions

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@klp2 klp2 merged commit 88c2af2 into main Jan 8, 2026
24 checks passed
@klp2 klp2 deleted the greg/eng-3756-update-gradle-instructions-in-readmemd-files branch January 8, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants