feat: enhance installation testing coverage (resolves #52) #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Session Handoff Updates: - Document PR #59 comprehensive validation results - Document incident: unintended host installation (17:29-18:56) - Document full rollback and resolution (no data lost) - Update startup prompt with critical warning - Document host machine modifications Generator Fix: - Remove printf %q over-escaping in generate-shortcuts.sh - Preserve variable expansion ($HOME, ${XDG_CONFIG_HOME}) - Fixes bookmark aliases: cf, cac, dt, etc. Incident resolved, all systems working. Next session: fix PR #59 blockers.
Implements all enhancements from Issue #52 to improve installation test coverage and boost agent score from 4.0 to 4.5+. High Priority Enhancements: - Add .zprofile symlink verification test - Add idempotency test (run install.sh twice) - Add artifact collection for failed CI runs - Fix ZDOTDIR expansion in install.sh by setting XDG_CONFIG_HOME Medium Priority Enhancements: - Add symlink target verification - Add conditional files testing (.gitconfig, inputrc) - Add backup functionality validation Low Priority Enhancements: - Add path-based workflow triggers (optimize CI runs) - Extract test logic to separate script (tests/installation-test.sh) - Add performance regression detection (30s threshold) Changes: - .github/workflows/shell-quality.yml: Enhanced installation-test job with all test improvements and diagnostic artifact collection - install.sh: Fixed ZDOTDIR expansion by setting XDG_CONFIG_HOME before evaluating extracted ZDOTDIR value - tests/installation-test.sh: New comprehensive test script that can be run standalone or in CI, with colored output and diagnostics All tests pass locally with 0 failures and <300ms execution time.
Critical fixes for PR #59: 1. Security: Replace eval with allowlist-based variable expansion - install.sh: Remove command injection vulnerability in ZDOTDIR expansion - Safe expansion of ${HOME} and ${XDG_CONFIG_HOME} patterns only 2. Testing: Add environment isolation to test script - tests/installation-test.sh: Unset inherited XDG variables before tests - Prevents tests from using parent environment settings 3. Code Quality: Fix 5 shellcheck SC2155 warnings - tests/installation-test.sh: Separate local declaration from assignment - Lines 171, 252, 279, 303, 304 - prevents masking return values 4. Documentation: Update README with comprehensive test coverage - Document 9 test scenarios from enhanced test suite - Update last modified date to 2025-11-03 Resolves #52
Fixes 3 remaining CI test failures: 1. Environment Isolation: Unset XDG variables in GitHub Actions - .github/workflows/shell-quality.yml: Add unset before install.sh runs - Prevents inheriting GitHub Actions environment settings - Ensures install.sh creates ZDOTDIR at expected test location 2. Shell Formatting: Apply shfmt formatting standards - tests/installation-test.sh: Fix redirect spacing (2> vs 2>) - tests/installation-test.sh: Fix inline comment spacing 3. Session Handoff: Document completed work per guidelines - SESSION_HANDOVER.md: Update with PR #59 fixes and next steps - Include required startup prompt format All changes ensure consistent test environment across Docker and CI.
The backup verification test unsets ZDOTDIR before running install.sh, then tries to use ZDOTDIR for verification. Add ZDOTDIR reset after install.sh completes to fix the check. This ensures the symlink verification at line 235 can find the .zshrc symlink at the expected location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements all enhancements from Issue #52 to improve installation test coverage.
Changes
Enhanced Test Coverage
tests/installation-test.sh) with 9 test scenariosSecurity Fixes
evalwith allowlist-based variable expansion in install.sh${HOME},${XDG_CONFIG_HOME},$HOME,$XDG_CONFIG_HOMETesting Infrastructure
Code Quality
Documentation
Test Results
All 9 CI checks passing:
Closes
Resolves #52