This repository was archived by the owner on Jan 20, 2025. It is now read-only.
Fix sending of bare (no data field) SSE events#1211
Open
docwilco wants to merge 1 commit intome-no-dev:masterfrom
Open
Fix sending of bare (no data field) SSE events#1211docwilco wants to merge 1 commit intome-no-dev:masterfrom
docwilco wants to merge 1 commit intome-no-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing things like
events->send(NULL, "foo");the text in the stream is missing the event's final CRLF, so browsers think multiple events are actually one big event.This PR fixes that by moving the final CRLF outside of
if(message != NULL).