[build] Extend logging for build-version script warning#3900
Open
vincesiu wants to merge 1 commit intomicro-editor:masterfrom
Open
[build] Extend logging for build-version script warning#3900vincesiu wants to merge 1 commit intomicro-editor:masterfrom
vincesiu wants to merge 1 commit intomicro-editor:masterfrom
Conversation
Spent some time figuring out what this error message meant. Hopefully I can save someone elses time. Context: Ran into this problem when cloning repo with --depth=1 and didnt grab latest tag. I thought build was broken but it was red herring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spent some time figuring out what this error message meant. Hopefully I can save someone else's time.
Context:
The build-version.go script uses a default if it can't find a tag, but I mistakenly thought the warning meant the build was broken. I ran into this problem when cloning repo with --depth=1 and didn't grab tags.
test
before
after
more log context