Fix exception when using default logger value for BackblazeClient constructors#34
Open
logiclrd wants to merge 2 commits intomicrocompiler:masterfrom
Open
Conversation
…he supplied logger value to NullLoggerFactory.Instance, so that if a caller constructs an instance of BackblazeClient using the default logger value (which is null) then it still works. Bumped the LangVersion in Backblaze.Client.csproj to 8.0 to support the null-coalescing operator.
….csproj with tests that passing null for the ILoggerFactory parameter does not cause a crash. Added a reference to NSubstitute to Backblaze.Tests.Unit.csproj.
logiclrd
force-pushed
the
JDG_FixBackblazeClientNonDefaultConstructors
branch
from
dae2174 to
65d11ee
Compare
Contributor
Author
|
Added regression tests. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
BackblazeClientclass has a few constructor overloads that take a bunch of parameters explicitly, including anILoggerFactory. The default value for these isnull. This was causing an exception deeper down because the base classStorageassumes it always has a validILoggerFactory. This PR fixes the issue by makingStoragesubstituteNullLoggerFactory.Instancewhen it receivesnull.