Modernize repo to latest everything, to run on Heroku again#85
Open
veganstraightedge wants to merge 44 commits intomicroformats:mainfrom
Open
Modernize repo to latest everything, to run on Heroku again#85veganstraightedge wants to merge 44 commits intomicroformats:mainfrom
veganstraightedge wants to merge 44 commits intomicroformats:mainfrom
Conversation
jgarber623
reviewed
Aug 15, 2025
Member
jgarber623
left a comment
There was a problem hiding this comment.
The diff here is too big for me to thoroughly review, but I did a quick test of the website at the link @veganstraightedge provided in the description and it appears to work just fine!
Tested with a URL and with an HTML snippet and validated that the results were as expected.
Contributor
Author
|
@aaronpk et al— can you review and merge this pls? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo running on Heroku
https://temp-mf-rb-b59ec22d01d4.herokuapp.com
Screenshots
(at the bottom of description)
Dependencies
3.2.2→3.4.5.5.2.0→8.0.24.1.3→5.3.70.58.2→1.79.21.4→3.0GitHub Action CI
Code changes
.rubocop_todo.ymlfor the last TODO to make (a db schema change)submissions/_form.html.erbtosubmissions/_submission.html.erb, sorender @submissionpattern worksenforce_utf8: falseAssets (Bootstrap)
Tests
Screenshots
Light mode
Dark mode