Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to the
BotbuilderandCorelibraries, as well as a test sample. The changes focus on improving type hints, imports, and method calls, as well as adding new configurations and optional fields.Improvements to type hints and imports:
libraries/Botbuilder/microsoft-agents-botbuilder/microsoft/agents/botbuilder/channel_service_adapter.py: Removed the unusedProtocolimport and updated theConnectorClientBaseandUserTokenClientBaseimports to includeConnectorClientandUserTokenClient. [1] [2]libraries/Core/microsoft-agents-core/microsoft/agents/core/models/conversation_reference.py: AddedOptionalimport fromtypingto handle optional fields.Method call improvements:
libraries/Botbuilder/microsoft-agents-botbuilder/microsoft/agents/botbuilder/channel_service_adapter.py: Updatedsend_to_conversationmethod call to useactivity.model_dump(by_alias=True, exclude_unset=True)to ensure only set fields are included.libraries/Botbuilder/microsoft-agents-botbuilder/microsoft/agents/botbuilder/channel_service_adapter.py: Added type hints forconnector_clientanduser_token_clientand ensured they are properly closed after use. [1] [2] [3]Configuration and optional fields:
libraries/Core/microsoft-agents-core/microsoft/agents/core/models/_agents_model.py: Addedpopulate_by_name = Trueto theConfigclass to enable population of fields by their name.libraries/Core/microsoft-agents-core/microsoft/agents/core/models/conversation_reference.py: Updatedactivity_idandlocalefields to be optional.Test sample updates:
test_samples/echo_bot/app.py: Replacedweb.Applicationandweb.run_appwithApplicationandrun_appfromaiohttp.webfor consistency and clarity. [1] [2]