Closed
Conversation
Member
|
@axelsrz , @rodrigobr-msft , @MattB-msft We might need to talk about this. The last time I talked to the Teams guy doing this, they felt this needed to be done through new TeamsConnectorClient operation instead of this structure. Matt, do you have a different understanding? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for "activity treatment" entities to the Microsoft Agents Activity library, improves the handling and serialization of entity types, and introduces some tests for these features. The most important changes are grouped below:
Activity Treatment Entity Support
ActivityTreatmententity and its type enumActivityTreatmentType, allowing activities to specify treatment information such as targeted delivery. (activity_treatment.py,__init__.py) [1] [2]get_activity_treatmentsmethod to theActivityclass to easily retrieve all activity treatment entities from an activity. (activity.py)Entity Type Improvements
EntityTypesclass to centralize entity type string constants (e.g., "mention", "activitytreatment"), and updated entity classes to use these constants for type assignment. (entity.py,mention.py,__init__.py) [1] [2] [3] [4]EntityTypesclass. (__init__.py,activity.py,mention.py) [1] [2] [3] [4]Testing and Serialization
get_mentions,get_activity_treatments) and for serialization/deserialization ofMentionandActivityTreatmententities, ensuring correct handling and compatibility with genericEntityobjects. (test_activity.py,test_entities.py) [1] [2]These changes enhance the extensibility and reliability of the activity entity system, making it easier to work with new entity types and ensuring robust serialization and extraction logic.