Turn State fixes and auto saving in application layer#107
Merged
Conversation
rodrigobr-msft
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to state management and middleware handling in the agent hosting core. The main updates include refactoring how state is cleared and saved, standardizing method signatures to consistently require
turn_context, and correcting logic in middleware execution. These changes improve code clarity, consistency, and ensure proper context is passed throughout the state lifecycle.State Management Improvements:
clearmethods inconversation_state.py,temp_state.py, andturn_state.pyto consistently requireturn_context, ensuring state operations have the necessary context. Theturn_state.pymethod now clears all scopes if none is specified. [1] [2] [3]savemethod totemp_state.pyto support saving state asynchronously.Middleware Logic Adjustments:
_on_turnto save state only if after-turn middleware succeeds, correcting the previous conditional.state.savein both before-turn and after-turn middleware to remove the explicit storage parameter, relying on context instead. [1] [2]Code Consistency:
agent_state.pyby explicitly checking forNonebefore invoking the factory, making the code more robust.