Setting flow state to COMPLETE when retrieving cached token#112
Merged
Setting flow state to COMPLETE when retrieving cached token#112
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR sets the OAuth flow state to COMPLETE when retrieving cached tokens and updates related test cases. The changes ensure proper state management when tokens are successfully obtained through the OAuth flow.
- Sets flow state tag to COMPLETE when tokens are retrieved successfully
- Updates test cases to expect the COMPLETE state in OAuth flow scenarios
- Updates method call from standalone function to instance method for AI metadata
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test_oauth_flow.py | Updates test expectations to verify flow state is set to COMPLETE when tokens are retrieved |
| oauth_flow.py | Sets flow state tag to COMPLETE after successful token retrieval |
| streaming_response.py | Changes from standalone function call to instance method for adding AI metadata |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…into users/robrandao/oauth-get-token-fix
axelsrz
approved these changes
Sep 9, 2025
rodrigobr-msft
added a commit
that referenced
this pull request
Sep 9, 2025
* Fixed reference to Activity.add_ai_metadata * Setting flow state to complete on get_token
axelsrz
added a commit
that referenced
this pull request
Sep 9, 2025
…oken (#112) (#113) * Setting flow state to COMPLETE when retrieving cached token (#112) * Fixed reference to Activity.add_ai_metadata * Setting flow state to complete on get_token * adding pipeline trigger to pr against release branch (#114) --------- Co-authored-by: Axel Suárez <axsuarez@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusting supporting test case