ActivityHandler unit tests and building/installing packages#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the CI/CD pipeline and improvements to the
ActivityHandlerclass in the Botbuilder library. The most important changes involve adding new dependencies, building and installing packages, refactoring methods, and adding new tests.CI/CD Pipeline Enhancements:
steps:in.azdo/ci-pr.yamland.github/workflows/python-package.ymlto includepytest-asyncioandbuildin the list of dependencies. [1] [2]distdirectory in both.azdo/ci-pr.yamland.github/workflows/python-package.yml. [1] [2]Botbuilder Library Improvements:
on_conversation_update_activitymethod inactivity_handler.pyto simplify the logic for handling members added or removed._create_invoke_responsemethod to handle cases where the body isNoneinactivity_handler.py._get_adaptive_card_invoke_valueto directly accessinvoke_value.action.typeinstead of usinggetmethod.Testing Enhancements:
ActivityHandlerintest_activity_handler.pyto cover various activity types and scenarios.Core Model Updates:
Configclass withConfigDictinagents_model.pyandentity.pyfor better configuration management. [1] [2] [3]