Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes to the
microsoft-agents-builderlibrary, focusing on OAuth flow management, card creation, and state management. The key changes include the addition of new modules for handling OAuth flows and card creation, updates to theChannelAdapterclass, and modifications to theUserTokenClientinstantiation.New Modules:
BasicOAuthFlowclass to manage OAuth flow for Web Chat, including methods for getting OAuth tokens, signing out, and retrieving user state. (libraries/Builder/microsoft-agents-builder/microsoft/agents/builder/basic_oauth_flow.py)CardFactoryclass to create various types of cards (e.g., adaptive, animation, audio, hero, OAuth, receipt, signin, thumbnail, video) with appropriate content types. (libraries/Builder/microsoft-agents-builder/microsoft/agents/builder/card_factory.py)Updates to
__init__.py:__init__.pyto includeBasicOAuthFlowandCardFactoryin the module exports. (libraries/Builder/microsoft-agents-builder/microsoft/agents/builder/__init__.py) [1] [2]Channel Adapter Enhancements:
CONNECTOR_FACTORY_KEY,USER_TOKEN_CLIENT_KEY,AGENT_CALLBACK_HANDLER_KEY,CHANNEL_SERVICE_FACTORY_KEY) to theChannelAdapterclass for better handling of connectors and token clients. (libraries/Builder/microsoft-agents-builder/microsoft/agents/builder/channel_adapter.py)ChannelServiceAdapterclass. (libraries/Builder/microsoft-agents-builder/microsoft/agents/builder/channel_service_adapter.py)User Token Client Modification:
create_user_token_clientmethod to include additional parameters (credential_resource_url,credential_scopes) for better token management. (libraries/Builder/microsoft-agents-builder/microsoft/agents/builder/rest_channel_service_client_factory.py)State Management:
AgentState,StatePropertyAccessor, andUserStateto the state management module's__init__.pyfile. (libraries/Builder/microsoft-agents-builder/microsoft/agents/builder/state/__init__.py)