Update parameter type hints and documentation across multiple files for clarity and consistency.#207
Merged
cleemullins merged 3 commits intomainfrom Oct 28, 2025
Merged
Conversation
…or clarity and consistency. Fixes all 43 errors identified in issue #204
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates parameter type hints and documentation across multiple files to address 43 errors identified in issue #204. The changes focus on improving clarity and consistency in documentation.
- Standardized documentation markup (replacing
.. remarks::with.. note::, updating code block syntax) - Enhanced type hints with fully qualified class paths for better IDE support
- Added missing return type documentation across multiple methods
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| channel_service_adapter.py | Updated documentation markers and added fully qualified type path for InvokeResponse; added docstring and Optional return type for _process_turn_results |
| channel_adapter.py | Enhanced parameter type documentation with fully qualified paths, added missing return type documentation, improved parameter descriptions |
| agent_application.py | Standardized documentation format, improved type hints with Callable signatures, updated example code blocks to use proper reStructuredText syntax |
| activity_handler.py | Added missing Awaitable import, updated documentation markers from remarks to note, added return type documentation, fixed method reference typos |
| msal_auth.py | Updated type hint with fully qualified class path for AgentAuthConfiguration |
| teams_channel_account.py | Corrected inline code formatting in parameter description |
| conversation_account.py | Corrected inline code formatting in parameter description |
| channel_account.py | Corrected inline code formatting in parameter description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...aries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/channel_service_adapter.py
Outdated
Show resolved
Hide resolved
…ng/core/channel_service_adapter.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
axelsrz
approved these changes
Oct 28, 2025
axelsrz
pushed a commit
that referenced
this pull request
Oct 31, 2025
…or clarity and consistency. (#207) * Update parameter type hints and documentation across multiple files for clarity and consistency. Fixes all 43 errors identified in issue #204 * Update libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/channel_service_adapter.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Chris Mullins <chmullins@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
axelsrz
added a commit
that referenced
this pull request
Oct 31, 2025
* Update parameter type hints and documentation across multiple files for clarity and consistency. (#207) * Update parameter type hints and documentation across multiple files for clarity and consistency. Fixes all 43 errors identified in issue #204 * Update libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/channel_service_adapter.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Chris Mullins <chmullins@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Proactive sample WIP (#213) * Proactive sample WIP * Proactive echo in teams WIP * Small fixes for proactive with experimental sample --------- Co-authored-by: Chris Mullins <cleemullins@users.noreply.github.com> Co-authored-by: Chris Mullins <chmullins@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204
Fixes all 43 errors identified in issue #204