Skip to content

Comments

Users/axsuarez/cheerypick 0.5 fixes#210

Merged
axelsrz merged 2 commits intorelease/0.5.0from
users/axsuarez/cheerypick-0.5-fixes
Oct 28, 2025
Merged

Users/axsuarez/cheerypick 0.5 fixes#210
axelsrz merged 2 commits intorelease/0.5.0from
users/axsuarez/cheerypick-0.5-fixes

Conversation

@axelsrz
Copy link
Member

@axelsrz axelsrz commented Oct 28, 2025

This pull request introduces several updates to the streaming response and typing indicator logic for Microsoft agents hosting. The main changes focus on improving channel detection for streaming, enhancing activity entity information, and refining error handling in the typing indicator loop.

Streaming channel detection and activity entity improvements:

  • Updated channel detection logic in _set_defaults to compare Channels.ms_teams and Channels.direct_line against context.activity.channel_id.channel, improving reliability in identifying streaming channels. (streaming_response.py)
  • Added stream_id to the Entity within create_activity, ensuring that activity entities include the stream identifier for better tracking. (streaming_response.py)

Typing indicator error handling:

  • Removed unnecessary re-raising of asyncio.CancelledError in the _typing_loop method, resulting in cleaner cancellation handling and reduced error noise. (typing_indicator.py)

* channel check changes needed for M365Copilot

* improving main channel check syntax
@axelsrz axelsrz requested a review from a team as a code owner October 28, 2025 19:18
@axelsrz axelsrz merged commit d34e62c into release/0.5.0 Oct 28, 2025
7 checks passed
@axelsrz axelsrz deleted the users/axsuarez/cheerypick-0.5-fixes branch October 28, 2025 19:19
Copilot AI mentioned this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant