Users/axsuarez/cherrypick proactive and docs#214
Merged
axelsrz merged 2 commits intorelease/0.5.0from Oct 31, 2025
Merged
Conversation
…or clarity and consistency. (#207) * Update parameter type hints and documentation across multiple files for clarity and consistency. Fixes all 43 errors identified in issue #204 * Update libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/channel_service_adapter.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Chris Mullins <chmullins@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Proactive sample WIP * Proactive echo in teams WIP * Small fixes for proactive with experimental sample
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to type annotations and documentation throughout the Microsoft Agents Activity and Hosting Core libraries. The main changes include updating optional type hints for model fields, improving docstring formatting and references, and adding precise return type annotations for async methods in the
ActivityHandlerclass.Type annotation and model improvements:
ChannelAccountandConversationAccountmodels to useOptionaltype hints, improving clarity for nullable fields. [1] [2] [3]is_groupfield inConversationAccounttoOptional[bool], and other fields toOptional[NonEmptyString]for better accuracy.Documentation enhancements:
idfields in several models (ChannelAccount,ConversationAccount,TeamsChannelAccount). [1] [2] [3]Async method return type annotations:
Awaitable[None]return type annotations to all async methods inActivityHandlerfor better type safety and documentation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]General docstring and naming corrections:
.. remarks::with.. note::in docstrings for consistency and readability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]These changes improve code clarity, maintainability, and developer experience by making type usage and documentation more precise and consistent.