Skip to content

Comments

Users/axsuarez/cherrypick proactive and docs#214

Merged
axelsrz merged 2 commits intorelease/0.5.0from
users/axsuarez/cherrypick-proactive-and-docs
Oct 31, 2025
Merged

Users/axsuarez/cherrypick proactive and docs#214
axelsrz merged 2 commits intorelease/0.5.0from
users/axsuarez/cherrypick-proactive-and-docs

Conversation

@axelsrz
Copy link
Member

@axelsrz axelsrz commented Oct 31, 2025

This pull request makes several improvements to type annotations and documentation throughout the Microsoft Agents Activity and Hosting Core libraries. The main changes include updating optional type hints for model fields, improving docstring formatting and references, and adding precise return type annotations for async methods in the ActivityHandler class.

Type annotation and model improvements:

  • Updated fields in ChannelAccount and ConversationAccount models to use Optional type hints, improving clarity for nullable fields. [1] [2] [3]
  • Changed the is_group field in ConversationAccount to Optional[bool], and other fields to Optional[NonEmptyString] for better accuracy.

Documentation enhancements:

  • Improved docstring formatting by wrapping example values in double backticks for id fields in several models (ChannelAccount, ConversationAccount, TeamsChannelAccount). [1] [2] [3]
  • Updated references in docstrings to use fully qualified class names and improved Sphinx-style references for clarity. [1] [2]

Async method return type annotations:

General docstring and naming corrections:

  • Replaced .. remarks:: with .. note:: in docstrings for consistency and readability. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Fixed typos and improved method references in documentation, such as correcting method names for reaction handling.

These changes improve code clarity, maintainability, and developer experience by making type usage and documentation more precise and consistent.

cleemullins and others added 2 commits October 31, 2025 00:49
…or clarity and consistency. (#207)

* Update parameter type hints and documentation across multiple files for clarity and consistency.

Fixes all 43 errors identified in issue #204

* Update libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/channel_service_adapter.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Chris Mullins <chmullins@microsoft.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Proactive sample WIP

* Proactive echo in teams WIP

* Small fixes for proactive with experimental sample
@axelsrz axelsrz requested a review from a team as a code owner October 31, 2025 07:57
@axelsrz axelsrz merged commit 841437e into release/0.5.0 Oct 31, 2025
7 checks passed
@axelsrz axelsrz deleted the users/axsuarez/cherrypick-proactive-and-docs branch October 31, 2025 07:59
Copilot AI mentioned this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants