Removing necessity of service_url when delivery_mode is expect_replies#258
Merged
rodrigobr-msft merged 7 commits intomainfrom Nov 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...aries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/channel_service_adapter.py
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...aries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/channel_service_adapter.py
Show resolved
Hide resolved
...aries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/channel_service_adapter.py
Show resolved
Hide resolved
MattB-msft
approved these changes
Nov 26, 2025
rodrigobr-msft
deleted the
users/robrandao/expect-replies-no-service-url
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves how connector clients are managed in the channel service adapter, ensuring that resources are only created and cleaned up when necessary. The main changes introduce a check to determine if a connector client is needed based on the activity's delivery mode and service URL, which helps prevent unnecessary resource allocation and potential errors.
Resource management improvements:
_resolve_if_connector_client_is_neededmethod to decide if a connector client should be created, based on the activity's delivery mode and presence of a service URL.process_activitymethod to only create and close aConnectorClientif it is actually needed, improving efficiency and preventing errors when the service URL is missing. [1] [2]Other minor improvements:
create_replymethod, wrappedservice_urlwithSkipNoneto handle cases where the value may beNone.