Merged
Conversation
tracyboehrer
reviewed
Jul 9, 2025
...-agents-hosting-aiohttp/microsoft/agents/hosting/aiohttp/app/streaming/streaming_response.py
Show resolved
Hide resolved
...-agents-hosting-aiohttp/microsoft/agents/hosting/aiohttp/app/streaming/streaming_response.py
Show resolved
Hide resolved
...-agents-hosting-aiohttp/microsoft/agents/hosting/aiohttp/app/streaming/streaming_response.py
Outdated
Show resolved
Hide resolved
…backlog" This reverts commit ba25de9.
tracyboehrer
previously approved these changes
Jul 15, 2025
Member
tracyboehrer
left a comment
There was a problem hiding this comment.
The only other consideration is the DotNet AgentApplication will call EndStream if needed. More of a request from Teams to ensure it's called even in the event of an exception.
rido-min
previously approved these changes
Jul 16, 2025
rido-min
approved these changes
Jul 16, 2025
MattB-msft
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and new features across multiple modules, focusing on streaming capabilities, AI-generated content handling, and citation utilities. The most significant changes include the addition of a
streaming_responseproperty to the turn context, support for AI entities in activities, and utility functions for citation management.Streaming Enhancements:
streaming_responseproperty toTurnContextinlibraries/Builder/microsoft-agents-builder/microsoft/agents/builder/turn_context.py, enabling partial response streaming to clients.StreamingResponse,StreamingChannelData, and related classes inlibraries/Hosting/microsoft-agents-hosting-aiohttp/microsoft/agents/hosting/aiohttp/app/streaming, providing foundational support for streaming operations. [1] [2]AI-Generated Content:
AIEntityand related models inlibraries/Core/microsoft-agents-core/microsoft/agents/core/models/ai_entity.pyto represent AI-generated content and citations. Also included a utility function,add_ai_to_activity, for associating AI entities with activities.Activityclass inlibraries/Core/microsoft-agents-core/microsoft/agents/core/models/activity.pyto support AI entities usingSerializeAsAny.Citation Utilities:
CitationUtilinlibraries/Hosting/microsoft-agents-hosting-aiohttp/microsoft/agents/hosting/aiohttp/app/streaming/citation_util.py, providing methods for formatting citation responses, clipping text, and extracting used citations from text.Miscellaneous Improvements:
model_dumpinConnectorClientto excludeNonevalues when replying to activities, optimizing payloads.__init__.pyfiles across modules to export new classes and utilities for broader accessibility. [1] [2] [3]