Merged
Conversation
|
Hi Axel, once this is merged, how long do we expect the libraries changes to be published to test pipy? I saw the last published release was May 19th 2025. I'm interested in picking up this cosmoDB change, as well as the streaming response change. |
axelsrz
reviewed
Jul 23, 2025
libraries/microsoft-agents-storage-cosmos/tests/test_key_ops.py
Outdated
Show resolved
Hide resolved
axelsrz
approved these changes
Jul 24, 2025
kylerohnmsft
pushed a commit
that referenced
this pull request
Jul 24, 2025
* Adding Cosmos DB storage * Removed unnecessary file * Added quick storage testing functionality for debugging and improved documentation * Simplified storage test setup and added unit test * Fixed legacy container support and added relevant tests * Revised AsyncStorageBase export/imports * Fixed final unit tests and refined documentation * Added microsoft-agent-cosmos to CI files * Minor fixes to storage tests * Moved files around * Fixed imports and formatted with black * Made key operation tests more data driven * Fixed minor issues in unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new CosmosDB storage library (
microsoft-agents-cosmos) and includes updates to existing storage libraries and testing. The most significant changes involve the addition of the new CosmosDB library and modifications to test structures.New CosmosDB Storage Library:
microsoft-agents-cosmos, including core files:cosmos_db_storage.py: Implements theCosmosDBStorageclass for managing CosmosDB storage operations.cosmos_db_storage_config.py: Provides configuration management for CosmosDB storage.key_ops.py: Contains utility functions for sanitizing and truncating keys.CosmosDBStorageandCosmosDBStorageConfigin the module’s__init__.py.pyproject.tomlfor packaging and dependencies, includingazure-cosmosandmicrosoft.agents.storage.Updates to CI/CD Pipelines:
.azdo/ci-pr.yamland.github/workflows/python-package.ymlto include installation of the newmicrosoft_agents_cosmospackage during CI builds. [1] [2]Codebase Simplifications:
blob_storage.pyto group related imports together.BlobStorageMockclass and related references intest_blob_storage.py. [1] [2]Enhancements to Tests:
test_external_change_is_visibleto verify that external changes to blob storage are correctly reflected.test_blob_storage.pyfor improved clarity.