Skip to content

Added default values for fields that are sometimes missing when communicating with MCS #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
axelsrz merged 2 commits into from
Aug 5, 2025
Merged

Added default values for fields that are sometimes missing when communicating with MCS #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09ec7b9
Added default values for fields that are sometimes missing when commu…
rodrigobr-msft Aug 4, 2025
e5fc438
Merge branch 'main' into users/robrandao/activity-fields-defaults
rodrigobr-msft Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/microsoft-agents-activity/microsoft/agents/activity/channel_account.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class ChannelAccount(AgentsModel):

model_config = ConfigDict(extra="allow")

id: NonEmptyString
id: NonEmptyString = None
name: str = None
aad_object_id: NonEmptyString = None
role: NonEmptyString = None
Expand Down
2 changes: 1 addition & 1 deletion libraries/microsoft-agents-activity/microsoft/agents/activity/conversation_reference.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class ConversationReference(AgentsModel):
conversation: ConversationAccount
channel_id: NonEmptyString
locale: Optional[NonEmptyString] = None
service_url: NonEmptyString
service_url: NonEmptyString = None

def get_continuation_activity(self) -> "Activity": # type: ignore
from .activity import Activity
Expand Down