Merged
Conversation
rodrigobr-msft
approved these changes
Aug 11, 2025
axelsrz
added a commit
that referenced
this pull request
Aug 12, 2025
* no config agent WIP * no config agent WIP. testing impact on other scenarios
axelsrz
added a commit
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactorings to both the core hosting logic and the test sample agent, focusing on simplifying configuration, improving error handling, and making the agent sample more approachable. The most significant changes are grouped below.
Core library improvements
CloudAdapterconstructor now allowsconnection_managerto be optional, defaulting toNone, making it easier to instantiate in simple scenarios.AgentApplicationinitialization, the requirement for aConnectionsinstance is removed if authorization is not explicitly provided. Instead, authorization options are filtered from configuration and passed directly, making setup more flexible and less error-prone._connection_manageris not configured when handling OAuth On-Behalf-Of (OBO) flows, improving clarity and debugging for misconfigurations.auth_configis present before accessing its properties, preventing potential runtime errors when configuration is missing or incomplete.Test sample and server refactoring
emtpy_agent.pysample is significantly simplified: unnecessary imports and manual configuration steps are removed, and the agent is now initialized with justMemoryStorageand aCloudAdapter. The help and echo behaviors are streamlined, and server startup is delegated to a sharedstart_serverutility.GET /api/messages) to aid in testing and monitoring.