Skip to content

Comments

Users/axsuarez/enable no config#88

Merged
axelsrz merged 2 commits intomainfrom
users/axsuarez/enable-no-config
Aug 12, 2025
Merged

Users/axsuarez/enable no config#88
axelsrz merged 2 commits intomainfrom
users/axsuarez/enable-no-config

Conversation

@axelsrz
Copy link
Member

@axelsrz axelsrz commented Aug 11, 2025

This pull request introduces several improvements and refactorings to both the core hosting logic and the test sample agent, focusing on simplifying configuration, improving error handling, and making the agent sample more approachable. The most significant changes are grouped below.

Core library improvements

  • The CloudAdapter constructor now allows connection_manager to be optional, defaulting to None, making it easier to instantiate in simple scenarios.
  • In the AgentApplication initialization, the requirement for a Connections instance is removed if authorization is not explicitly provided. Instead, authorization options are filtered from configuration and passed directly, making setup more flexible and less error-prone.
  • Added an explicit error and exception if _connection_manager is not configured when handling OAuth On-Behalf-Of (OBO) flows, improving clarity and debugging for misconfigurations.
  • The JWT authorization middleware now checks if auth_config is present before accessing its properties, preventing potential runtime errors when configuration is missing or incomplete.

Test sample and server refactoring

  • The emtpy_agent.py sample is significantly simplified: unnecessary imports and manual configuration steps are removed, and the agent is now initialized with just MemoryStorage and a CloudAdapter. The help and echo behaviors are streamlined, and server startup is delegated to a shared start_server utility.
  • The shared server utility now adds a health check endpoint (GET /api/messages) to aid in testing and monitoring.

@axelsrz axelsrz merged commit ece33e1 into main Aug 12, 2025
5 checks passed
@axelsrz axelsrz deleted the users/axsuarez/enable-no-config branch August 12, 2025 18:33
axelsrz added a commit that referenced this pull request Aug 12, 2025
* no config agent WIP

* no config agent WIP. testing impact on other scenarios
axelsrz added a commit that referenced this pull request Aug 12, 2025
* no config agent WIP

* no config agent WIP. testing impact on other scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants