Skip to content

[Security/Stability] Harden Codegen against Division by Zero and Null Pointers #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DT-Foss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Security/Stability] Harden Codegen against Division by Zero and Null Pointers #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions utils/codegen_tl1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,12 +345,26 @@ def gen_transform_code(kernel_shape):
}}\n".format(kernel_shapes[i][0], kernel_shapes[i][1])])

kernel_code = "".join([kernel_code, "\n\
if (bm == 0) {{\n\
fprintf(stderr, \"ggml_bitnet_transform_tensor: unsupported tensor dimensions m=%d, k=%d\\n\", m, k);\n\
return;\n\
}}\n\
\n\
if (tensor->data == nullptr) {{\n\
fprintf(stderr, \"ggml_bitnet_transform_tensor: tensor->data is null\\n\");\n\
return;\n\
}}\n\
\n\
const int n_tile_num = m / bm;\n\
const int BK = bk;\n\
uint8_t * qweights;\n\
bitnet_float_type * scales;\n\
\n\
scales = (bitnet_float_type *) aligned_malloc(sizeof(bitnet_float_type));\n\
if (scales == nullptr) {{\n\
fprintf(stderr, \"ggml_bitnet_transform_tensor: failed to allocate scales\\n\");\n\
return;\n\
}}\n\
qweights = (uint8_t *) tensor->data;\n\
float * i2_scales = (float * )(qweights + k * m / 4);\n\
scales[0] = (bitnet_float_type) i2_scales[0];\n\
Expand Down
14 changes: 14 additions & 0 deletions utils/codegen_tl2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,12 +649,26 @@ def gen_transform_code(kernel_shapes):
}}\n".format(kernel_shapes[i][0], kernel_shapes[i][1])])

kernel_code = "".join([kernel_code, "\n\
if (bm == 0) {{\n\
fprintf(stderr, \"ggml_bitnet_transform_tensor: unsupported tensor dimensions m=%d, k=%d\\n\", m, k);\n\
return;\n\
}}\n\
\n\
if (tensor->data == nullptr) {{\n\
fprintf(stderr, \"ggml_bitnet_transform_tensor: tensor->data is null\\n\");\n\
return;\n\
}}\n\
\n\
const int n_tile_num = m / bm;\n\
const int BK = bk;\n\
uint8_t * qweights;\n\
bitnet_float_type * scales;\n\
\n\
scales = (bitnet_float_type *) aligned_malloc(sizeof(bitnet_float_type));\n\
if (scales == nullptr) {{\n\
fprintf(stderr, \"ggml_bitnet_transform_tensor: failed to allocate scales\\n\");\n\
return;\n\
}}\n\
qweights = (uint8_t *) tensor->data;\n\
int nbytes = (k - 256) * m / 3 * 5 / 8 + 256 * m / 2 * 4 / 8;\n\
if (nbytes % 32 != 0) nbytes = 32 - nbytes % 32 + nbytes;\n\
Expand Down