Skip to content

Remove unnecessary unsafe modifiers from classes and methods #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sergio0694 wants to merge 1 commit into
base: staging/3.0
Choose a base branch
from
Open

Remove unnecessary unsafe modifiers from classes and methods #2158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/WinRT.Runtime2/ABI/System/Collections/IEnumerable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public override object CreateObject(void* value, out CreatedWrapperFlags wrapper
DiagnosticId = WindowsRuntimeConstants.PrivateImplementationDetailObsoleteDiagnosticId,
UrlFormat = WindowsRuntimeConstants.CsWinRTDiagnosticsUrlFormat)]
[EditorBrowsable(EditorBrowsableState.Never)]
public static unsafe class IEnumerableMethods
public static class IEnumerableMethods
{
/// <inheritdoc cref="global::System.Collections.IEnumerable.GetEnumerator"/>
public static global::System.Collections.IEnumerator GetEnumerator(WindowsRuntimeObjectReference thisReference)
Expand Down
2 changes: 1 addition & 1 deletion src/WinRT.Runtime2/ABI/System/Collections/IEnumerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public override object CreateObject(void* value, out CreatedWrapperFlags wrapper
DiagnosticId = WindowsRuntimeConstants.PrivateImplementationDetailObsoleteDiagnosticId,
UrlFormat = WindowsRuntimeConstants.CsWinRTDiagnosticsUrlFormat)]
[EditorBrowsable(EditorBrowsableState.Never)]
public static unsafe class IEnumeratorMethods
public static class IEnumeratorMethods
{
/// <inheritdoc cref="global::System.Collections.IEnumerator.Current"/>
public static object? Current(WindowsRuntimeObjectReference thisReference)
Expand Down
2 changes: 1 addition & 1 deletion src/WinRT.Runtime2/ABI/System/Collections/IList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public override object CreateObject(void* value, out CreatedWrapperFlags wrapper
DiagnosticId = WindowsRuntimeConstants.PrivateImplementationDetailObsoleteDiagnosticId,
UrlFormat = WindowsRuntimeConstants.CsWinRTDiagnosticsUrlFormat)]
[EditorBrowsable(EditorBrowsableState.Never)]
public static unsafe class IListMethods
public static class IListMethods
{
/// <inheritdoc cref="ICollection.Count"/>
public static int Count(WindowsRuntimeObjectReference thisReference)
Expand Down
2 changes: 1 addition & 1 deletion src/WinRT.Runtime2/ABI/System/Collections/Specialized/INotifyCollectionChanged.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public static WindowsRuntimeObjectReferenceValue ConvertToUnmanaged(INotifyColle
DiagnosticId = WindowsRuntimeConstants.PrivateImplementationDetailObsoleteDiagnosticId,
UrlFormat = WindowsRuntimeConstants.CsWinRTDiagnosticsUrlFormat)]
[EditorBrowsable(EditorBrowsableState.Never)]
public static unsafe class INotifyCollectionChangedMethods
public static class INotifyCollectionChangedMethods
{
/// <summary>
/// The <see cref="EventSource{T}"/> table for <see cref="INotifyCollectionChanged.CollectionChanged"/>.
Expand Down
2 changes: 1 addition & 1 deletion src/WinRT.Runtime2/ABI/System/ComponentModel/INotifyPropertyChanged.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public static WindowsRuntimeObjectReferenceValue ConvertToUnmanaged(INotifyPrope
DiagnosticId = WindowsRuntimeConstants.PrivateImplementationDetailObsoleteDiagnosticId,
UrlFormat = WindowsRuntimeConstants.CsWinRTDiagnosticsUrlFormat)]
[EditorBrowsable(EditorBrowsableState.Never)]
public static unsafe class INotifyPropertyChangedMethods
public static class INotifyPropertyChangedMethods
{
/// <summary>
/// The <see cref="EventSource{T}"/> table for <see cref="INotifyPropertyChanged.PropertyChanged"/>.
Expand Down
2 changes: 1 addition & 1 deletion src/WinRT.Runtime2/ABI/Windows.Foundation/IAsyncAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public static WindowsRuntimeObjectReferenceValue ConvertToUnmanaged(IAsyncAction
file abstract unsafe class IAsyncActionComWrappersCallback : IWindowsRuntimeUnsealedObjectComWrappersCallback
{
/// <inheritdoc/>
public static unsafe bool TryCreateObject(
public static bool TryCreateObject(
void* value,
ReadOnlySpan<char> runtimeClassName,
[NotNullWhen(true)] out object? wrapperObject,
Expand Down
2 changes: 1 addition & 1 deletion src/WinRT.Runtime2/Bindables/WindowsRuntimeIterator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace WindowsRuntime;
/// The implementation of all projected Windows Runtime <see cref="IEnumerator"/> types.
/// </summary>
/// <see href="https://learn.microsoft.com/uwp/api/windows.ui.xaml.interop.ibindableiterator"/>
internal sealed unsafe class WindowsRuntimeIterator : WindowsRuntimeObject, IEnumerator, IWindowsRuntimeInterface<IEnumerator>
internal sealed class WindowsRuntimeIterator : WindowsRuntimeObject, IEnumerator, IWindowsRuntimeInterface<IEnumerator>
{
/// <summary>
/// Indicates whether the underlying enumerator has been initialized.
Expand Down
2 changes: 1 addition & 1 deletion src/WinRT.Runtime2/Collections/WindowsRuntimeEnumerator{T}.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ namespace WindowsRuntime;
DiagnosticId = WindowsRuntimeConstants.PrivateImplementationDetailObsoleteDiagnosticId,
UrlFormat = WindowsRuntimeConstants.CsWinRTDiagnosticsUrlFormat)]
[EditorBrowsable(EditorBrowsableState.Never)]
public abstract unsafe class WindowsRuntimeEnumerator<T, TIIteratorMethods> : WindowsRuntimeObject, IEnumerator<T>, IWindowsRuntimeInterface<IEnumerator<T>>
public abstract class WindowsRuntimeEnumerator<T, TIIteratorMethods> : WindowsRuntimeObject, IEnumerator<T>, IWindowsRuntimeInterface<IEnumerator<T>>
where TIIteratorMethods : IIteratorMethodsImpl<T>
{
/// <summary>
Expand Down
10 changes: 5 additions & 5 deletions src/WinRT.Runtime2/InteropServices/Activation/WindowsRuntimeActivationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ internal static unsafe class WindowsRuntimeActivationHelper
/// </remarks>
/// <see href="https://learn.microsoft.com/uwp/winrt-cref/winrt-type-system#composable-activation"/>
[MethodImpl(MethodImplOptions.NoInlining)]
public static unsafe void ActivateInstanceUnsafe(WindowsRuntimeObjectReference activationFactoryObjectReference, out void* defaultInterface)
public static void ActivateInstanceUnsafe(WindowsRuntimeObjectReference activationFactoryObjectReference, out void* defaultInterface)
{
using WindowsRuntimeObjectReferenceValue activationFactoryValue = activationFactoryObjectReference.AsValue();

Expand All @@ -50,7 +50,7 @@ public static unsafe void ActivateInstanceUnsafe(WindowsRuntimeObjectReference a
/// <param name="defaultInterface">The resulting default interface pointer.</param>
/// <exception cref="Exception">Thrown if activating the instance fails.</exception>
[MethodImpl(MethodImplOptions.NoInlining)]
public static unsafe void ActivateInstanceUnsafe(
public static void ActivateInstanceUnsafe(
WindowsRuntimeObjectReference activationFactoryObjectReference,
string? param0,
out void* defaultInterface)
Expand Down Expand Up @@ -85,7 +85,7 @@ public static unsafe void ActivateInstanceUnsafe(
/// </remarks>
/// <see href="https://learn.microsoft.com/uwp/winrt-cref/winrt-type-system#composable-activation"/>
[MethodImpl(MethodImplOptions.NoInlining)]
public static unsafe void ActivateInstanceUnsafe(
public static void ActivateInstanceUnsafe(
WindowsRuntimeObjectReference activationFactoryObjectReference,
WindowsRuntimeObject? baseInterface,
out void* innerInterface,
Expand Down Expand Up @@ -113,7 +113,7 @@ public static unsafe void ActivateInstanceUnsafe(
/// </remarks>
/// <inheritdoc cref="ActivateInstanceUnsafe(WindowsRuntimeObjectReference, WindowsRuntimeObject?, out void*, out void*)"/>
[MethodImpl(MethodImplOptions.NoInlining)]
public static unsafe void ActivateInstanceUnsafe(
public static void ActivateInstanceUnsafe(
WindowsRuntimeObjectReference activationFactoryObjectReference,
string? param0,
WindowsRuntimeObject? baseInterface,
Expand Down Expand Up @@ -150,7 +150,7 @@ public static unsafe void ActivateInstanceUnsafe(
/// </remarks>
/// <inheritdoc cref="ActivateInstanceUnsafe(WindowsRuntimeObjectReference, WindowsRuntimeObject?, out void*, out void*)"/>
[MethodImpl(MethodImplOptions.NoInlining)]
public static unsafe void ActivateInstanceUnsafe(
public static void ActivateInstanceUnsafe(
WindowsRuntimeObjectReference activationFactoryObjectReference,
NotifyCollectionChangedAction param0,
IList? param1,
Expand Down
2 changes: 1 addition & 1 deletion src/WinRT.Runtime2/InteropServices/ObjectReference/FreeThreadedObjectReference.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ internal override HRESULT DerivedTryAsNative(in Guid iid, out WindowsRuntimeObje
}

/// <inheritdoc/>
private protected override unsafe void* GetThisPtrWithContextUnsafe()
private protected override void* GetThisPtrWithContextUnsafe()
{
// This method is never called for free-threaded objects
return null;
Expand Down
2 changes: 1 addition & 1 deletion src/WinRT.Runtime2/InteropServices/Platform/WindowsRuntimeImports.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ internal static unsafe partial class WindowsRuntimeImports

/// <see href="https://learn.microsoft.com/windows/win32/api/combaseapi/nf-combaseapi-coincrementmtausage"/>
[LibraryImport("api-ms-win-core-com-l1-1-0.dll")]
public static unsafe partial HRESULT CoIncrementMTAUsage(CO_MTA_USAGE_COOKIE* cookie);
public static partial HRESULT CoIncrementMTAUsage(CO_MTA_USAGE_COOKIE* cookie);

/// <see href="https://learn.microsoft.com/windows/win32/api/combaseapi/nf-combaseapi-codecrementmtausage"/>
[LibraryImport("api-ms-win-core-com-l1-1-0.dll")]
Expand Down
2 changes: 1 addition & 1 deletion src/WinRT.Runtime2/InteropServices/ProjectionImpls/IAgileObjectImpl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace WindowsRuntime.InteropServices;
DiagnosticId = WindowsRuntimeConstants.PrivateImplementationDetailObsoleteDiagnosticId,
UrlFormat = WindowsRuntimeConstants.CsWinRTDiagnosticsUrlFormat)]
[EditorBrowsable(EditorBrowsableState.Never)]
public static unsafe class IAgileObjectImpl
public static class IAgileObjectImpl
{
/// <summary>
/// Gets a pointer to the managed <c>IAgileObject</c> implementation.
Expand Down
Loading