Tag asserts (#26039)

## Description

`pnpm run policy-check:asserts`

Done using branch from
#26036 to workaround
issue noted in that PR.

Author: CraigMacomber

packages/dds/tree/src/feature-libraries/modular-schema/comparison.ts

@@ -163,7 +163,8 @@ export function allowsFieldSuperset(
 	if (monotonicOnly) {
 		return supersetKind.options.allowMonotonicUpgradeFrom.has(original.kind);
 	} else {
-		const originalKind = policy.fieldKinds.get(original.kind) ?? fail("missing kind");
+		const originalKind =
+			policy.fieldKinds.get(original.kind) ?? fail(0xcab /* missing kind */);
 		return allowsMultiplicitySuperset(originalKind.multiplicity, supersetKind.multiplicity);
 	}
 }

packages/dds/tree/src/shared-tree-core/editManagerCodecsVSharedBranches.ts

@@ -78,7 +78,7 @@ export function makeSharedBranchesCodecWithVersion<TChangeset>(
 				);
 				assert(
 					data.originator !== undefined,
-					"Cannot encode vSharedBranches summary without originator",
+					0xca5 /* Cannot encode vSharedBranches summary without originator */,
 				);
 				const json: Mutable<EncodedEditManager<TChangeset>> = {
 					main: mainBranch,

packages/dds/tree/src/shared-tree-core/versionedSummarizer.ts

@@ -44,7 +44,7 @@ export abstract class VersionedSummarizer<TVersion extends number> implements Su
 	) {
 		assert(
 			this.supportedVersions.has(this.writeVersion),
-			"Unsupported write version requested.",
+			0xca6 /* Unsupported write version requested. */,
 			() => `Write version ${this.writeVersion} requested but not supported with key ${key}.`,
 		);
 	}

packages/dds/tree/src/shared-tree/treeCheckout.ts

@@ -559,7 +559,10 @@ export class TreeCheckout implements ITreeCheckoutFork {
 							.resolve(4)
 							.json.encode(change, context);
 
-						assert(commit.parent !== undefined, "Expected applied commit to be parented");
+						assert(
+							commit.parent !== undefined,
+							0xca4 /* Expected applied commit to be parented */,
+						);
 						return {
 							version: 1,
 							revision,

packages/dds/tree/src/simple-tree/createContext.ts

@@ -33,7 +33,10 @@ export function getUnhydratedContext(schema: ImplicitFieldSchema): Context {
 	// Due to caching, calling this reentrantly can cause issues.
 	// Due to recursive schema, and generally lots of lazy initialization code depending on this, bugs with this going reentrant are not uncommon.
 	// To make debugging such cases much easier, we assert that this is not called reentrantly.
-	assert(!getUnhydratedContextIsRunning, "getUnhydratedContext should not be reentrant");
+	assert(
+		!getUnhydratedContextIsRunning,
+		0xca7 /* getUnhydratedContext should not be reentrant */,
+	);
 	getUnhydratedContextIsRunning = true;
 	try {
 		return getOrCreate(contextCache, schema, (s) => {

packages/dds/tree/src/simple-tree/toStoredSchema.ts

@@ -189,7 +189,7 @@ export function transformSimpleSchema(
 	const queue = Array.from(root.simpleAllowedTypes.keys());
 	for (const identifier of queue) {
 		getOrCreate(simpleNodeSchema, identifier, (id) => {
-			const nodeSchema = schema.definitions.get(id) ?? fail("missing schema");
+			const nodeSchema = schema.definitions.get(id) ?? fail(0xca8 /* missing schema */);
 			const transformed = transformSimpleNodeSchema(nodeSchema, options);
 			const kind = transformed.kind;
 			switch (kind) {
@@ -216,12 +216,12 @@ export function transformSimpleSchema(
 	const definitions = new Map<string, SimpleNodeSchema>(
 		mapIterable(
 			filterIterable(schema.definitions.keys(), (id) => simpleNodeSchema.has(id)),
-			(id) => [id, simpleNodeSchema.get(id) ?? fail("missing schema")],
+			(id) => [id, simpleNodeSchema.get(id) ?? fail(0xca9 /* missing schema */)],
 		),
 	);
 	assert(
 		definitions.size === simpleNodeSchema.size,
-		"Reachable schema missing from input TreeSchema",
+		0xcaa /* Reachable schema missing from input TreeSchema */,
 	);
 	return { root, definitions };
 }

packages/runtime/test-runtime-utils/src/assertionShortCodesMap.ts

@@ -1433,7 +1433,6 @@ export const shortCodeMap = {
 	"0xa7b": "Collision of object id property.",
 	"0xa7c": "Ref not found.",
 	"0xa7d": "Expected at least two types",
-	"0xa7e": "Expected at least two types",
 	"0xa7f": "Delta manager does not have inbound/outbound queues.",
 	"0xa80": "Invalid delta manager",
 	"0xa83": "Expected commit(s) for a non no-op rebase",
@@ -1624,7 +1623,6 @@ export const shortCodeMap = {
 	"0xb5d": "Expected last remove to be unacked",
 	"0xb5e": "Expected prior remove to be acked",
 	"0xb5f": "Expected same length for client ids and seqs",
-	"0xb60": "Invalid schema",
 	"0xb61": "Invalid old reference",
 	"0xb62": "Invalid new segment on rebase",
 	"0xb63": "Resubmitting obliterate op without obliterate info in segment group",
@@ -1841,7 +1839,6 @@ export const shortCodeMap = {
 	"0xc62": "Cannot encode branch base without originatorId",
 	"0xc63": "Cannot decode branch id without originatorId",
 	"0xc64": "Cannot decode branch base without originatorId",
-	"0xc65": "Cannot encode V5 summary without originator",
 	"0xc66": "Shared branches must have an id",
 	"0xc67": "Duplicate shared branch id",
 	"0xc68": "Only commit messages are supported",
@@ -1902,5 +1899,13 @@ export const shortCodeMap = {
 	"0xca0": "Unsupported FieldBatchFormatVersion for incremental encoding; must be v2 or higher",
 	"0xca1": "Unsupported FieldBatchFormatVersion for incremental encoding; must be v2 or higher",
 	"0xca2": "localOpActivity must be undefined when entering rollback",
-	"0xca3": "localOpActivity must be undefined when entering applyStashedOp"
+	"0xca3": "localOpActivity must be undefined when entering applyStashedOp",
+	"0xca4": "Expected applied commit to be parented",
+	"0xca5": "Cannot encode vSharedBranches summary without originator",
+	"0xca6": "Unsupported write version requested.",
+	"0xca7": "getUnhydratedContext should not be reentrant",
+	"0xca8": "missing schema",
+	"0xca9": "missing schema",
+	"0xcaa": "Reachable schema missing from input TreeSchema",
+	"0xcab": "missing kind"
 };