Increase MAX_ENTRIES limit in ZipBombChecker to support larger test packages #714
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increased
MAX_ENTRIESlimit from 10,000 to 20,000 inZipBombChecker.javato support uploading larger test packages with more files.Problem: Test packages (e.g., iOS XCTest bundles) can contain more than 10,000 files, causing the zip bomb detection to incorrectly reject legitimate uploads.
Solution: Increased the
MAX_ENTRIESconstant to 20,000 to accommodate larger packages while still protecting against zip bomb attacks.Linked GitHub issue ID:
Pull Request Checklist
Does this introduce a breaking change?
How you tested it
:common:test- all tests passPlease check the type of change your PR introduces:
Feature UI screenshots or Technical design diagrams
N/A - Configuration change only.