Update MSBL001 to recommend ExcludeAssets="runtime" and PrivateAssets="all"#366
Merged
YuliiaKovalova merged 2 commits intomainfrom Nov 25, 2025
Merged
Update MSBL001 to recommend ExcludeAssets="runtime" and PrivateAssets="all"#366YuliiaKovalova merged 2 commits intomainfrom
YuliiaKovalova merged 2 commits intomainfrom
Conversation
… PrivateAssets="all" Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix MSBL001 diagnostic suggestions for NuGet dependencies
Update MSBL001 to recommend ExcludeAssets="runtime" and PrivateAssets="all"
Nov 25, 2025
YuliiaKovalova
approved these changes
Nov 25, 2025
YuliiaKovalova
added a commit
that referenced
this pull request
Nov 25, 2025
…="all" (#367) * Revise release steps for MSBuildLocator (#365) * Revise release steps for MSBuildLocator Updated the release process for MSBuildLocator to reflect changes in the pipeline build and release steps. * Remove GitHub release job from pipeline * Fix typo in pipeline build instruction * Update MSBL001 to recommend ExcludeAssets="runtime" and PrivateAssets="all" (#366) * Initial plan * Update MSBL001 diagnostic to suggest both ExcludeAssets="runtime" and PrivateAssets="all" Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExcludeAssets="runtime"alone doesn't prevent package reference metadata from flowing transitively to downstream projects. Projects referencing a library with MSBuild packages still get runtime assets, triggering MSBL001 even when the library correctly excludes them.Adding
PrivateAssets="all"prevents the reference from flowing to consumers entirely—the right behavior since MSBuildLocator handles finding these assemblies at runtime.Changes
Microsoft.Build.Locator.targets: Updated MSBL001 error message to suggest both attributesdocs/diagnostics/MSBL001.md: Updated documentation to explain transitive flow issue and show corrected solutionSolution
Fixes #364
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.