Change PrivateAssets from "all" to "runtime" in MSBL001 diagnostic#370
Draft
Change PrivateAssets from "all" to "runtime" in MSBL001 diagnostic#370
Conversation
Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update warning to use PrivateAssets="runtime" instead of all
Change PrivateAssets from "all" to "runtime" in MSBL001 diagnostic
Dec 2, 2025
YuliiaKovalova
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requiring
PrivateAssets="all"can break downstream projects that need compile-time references to MSBuild packages. OnlyPrivateAssets="runtime"is actually needed sinceExcludeAssets="runtime"already handles the runtime exclusion.Changes
src/MSBuildLocator/build/Microsoft.Build.Locator.targets- Updated MSBL001 error message to prescribePrivateAssets="runtime"docs/diagnostics/MSBL001.md- Updated documentation and examples to usePrivateAssets="runtime"Recommended PackageReference
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.