feat: gate std::io usage behind io feature
#422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…log_ext` macro `std::io::Read::read_exact` was used before, which indirectly is a single call to `digest::XofReader::read` in this scenario
Also, uses `bincode`s `EncodeError` instead of `io::Error`. In practice, no error is ever returned.
JayWhite2357
force-pushed
the
feat/io-gate
branch
from
564af8e to
51c645b
Compare
JayWhite2357
force-pushed
the
feat/io-gate
branch
from
51c645b to
e72926a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
There are several places that
iois used. This can be problematic, particularly for constrained targets (wasm, etc).Changes
In some places
std::iousage can/should be removed.In others, it is unavoidable, but is be gated behind an
iofeature flag.See the individual commit messages for details.