Remove KeyComparer property from OpenApiWriterSettings

[Copilot]

Following discussions in #2363, this PR removes the KeyComparer property from OpenApiWriterSettings class as ordered collections are sufficient for the library's needs.

Changes Made

• Removed KeyComparer property from OpenApiWriterSettings.cs
• Updated writer logic in OpenApiWriterExtensions.cs to remove custom sorting:
  • Removed KeyComparer usage from WriteCollectionInternal method
  • Removed KeyComparer usage from WriteMapInternal method
• Cleaned up tests in CollectionExtensionsTests.cs:
  • Removed SortOpenApiDocumentUsingCustomComparerSucceeds test
  • Removed SortHashSetsWorks test
  • Removed SortTagsByNameUsingComparerWorks test and associated OpenApiTagNameComparer class
• Removed unused extension methods from CollectionExtensions.cs:
  • Removed Sort<TKey, TValue> method for dictionaries
  • Removed Sort<T> method for enumerables
• Updated public API surface in PublicApi.approved.txt to reflect removed property

Impact

The removal of custom comparer functionality aligns with the decision to rely on ordered collections instead. Collections and maps will now be written in their natural order rather than using custom sorting logic.

Testing

• All existing functionality continues to work as expected
• Build passes successfully for all target frameworks
• No breaking changes to core serialization behavior

Fixes #2374.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• http://168.63.129.16:80/machine/
  • Triggering command: /usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs (http block)
• http://www.microsoft.com:80/pkiops/crl/Microsoft%20Identity%20Verification%20Root%20Certificate%20Authority%202020.crl
  • Triggering command: dotnet build (http block)
• http://www.microsoft.com:80/pkiops/crl/Microsoft%20Public%20RSA%20Timestamping%20CA%202020.crl
  • Triggering command: dotnet build (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• http://168.63.129.16:80/machine/
  • Triggering command: /usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[peombwa]

@baywet, shouldn't the PR title be renamed to match conventional commit. i.e. fix: XYZ?

[baywet]

@baywet, shouldn't the PR title be renamed to match conventional commit. i.e. fix: XYZ?

@peombwa why would you expect the PR title to match the conventional commit name?

[peombwa]

@baywet, shouldn't the PR title be renamed to match conventional commit. i.e. fix: XYZ?

@peombwa why would you expect the PR title to match the conventional commit name?

@baywet, this is based on the naming convention used for closed PRs in this repo - https://github.com/microsoft/OpenAPI.NET/pulls?q=is%3Apr+is%3Aclosed. However, based on the releases, it appears that release notes are generated from commit messages rather than PR titles.

[peombwa]

LGTM

[baywet]

Yes release notes are using the commits messages.
The GitHub UI adds the PR title in the merge commit message.
The GitHub CLI uses the commit message as PR title if it's a single commit.
This is why things can appear multiple places.

[bkoelman]

Thanks!