Skip to content

Migrate Crypto to KDL #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 10 commits into from
Dec 8, 2025
Merged

Migrate Crypto to KDL #2277

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5e39633
Migrate Crypto to KDL
Bashamega Dec 8, 2025
2413e11
Adds extra line
Bashamega Dec 8, 2025
6542ff8
rename to webcrypto.kdl
saschanaz Dec 8, 2025
aad3886
update
Bashamega Dec 8, 2025
0c5779b
-
Bashamega Dec 8, 2025
7fc7cb6
2-space
saschanaz Dec 8, 2025
e917860
2-space
saschanaz Dec 8, 2025
25525f2
2-space
saschanaz Dec 8, 2025
f76bc39
newlines between items (unless they are closely related to each other)
saschanaz Dec 8, 2025
e642396
Remove redundant newline in webcrypto.kdl
saschanaz Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions inputfiles/patches/crypto-public.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
removals {
Copy link
Collaborator

@saschanaz saschanaz Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should go to webauthn.kdl which already exists

dictionary PublicKeyCredentialCreationOptions {
member attestationFormats // Blink only as of 2024-08
member hints // Blink only as of 2024-08
}

dictionary PublicKeyCredentialCreationOptionsJSON {
member attestationFormats // Gecko only as of 2024-08
}

dictionary PublicKeyCredentialRequestOptions {
member hints // Blink only as of 2024-08
}
}
37 changes: 37 additions & 0 deletions inputfiles/patches/crypto.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,40 @@ interface CryptoKey {
}
}
}

removals {
enum KeyFormat {
raw-private // No implementation as of 2025-09
raw-public // No implementation as of 2025-09
raw-secret // No implementation as of 2025-09
raw-seed // No implementation as of 2025-09
}

enum KeyUsage {
decapsulateBits // No implementation as of 2025-09
decapsulateKey // No implementation as of 2025-09
encapsulateBits // No implementation as of 2025-09
encapsulateKey // No implementation as of 2025-09
}

dictionary KeySystemTrackConfiguration {
member encryptionScheme // Gecko only as of 2025-05
}

dictionary CredentialRequestOptions {
// Only `mediation`, `publicKey`, `signal` are implemented by 2+ engines, everything else is currently Blink only.
// https://searchfox.org/mozilla-central/source/dom/webidl/CredentialManagement.webidl
// https://searchfox.org/wubkat/source/Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.idl
// https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/credentialmanagement/credential_request_options.idl
member digital // Behind a flag in WebKit and Blink as of 2024-03
member federated
member identity
member otp
member password
}

dictionary JsonWebKey {
member priv // No implementation as of 2025-09
member pub // No implementation as of 2025-09
}
}
68 changes: 0 additions & 68 deletions inputfiles/removedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,6 @@
"ConnectionType": {
"value": ["wimax"]
},
"KeyFormat": {
"value": [
"raw-private", // No implementation as of 2025-09
"raw-public", // No implementation as of 2025-09
"raw-secret", // No implementation as of 2025-09
"raw-seed" // No implementation as of 2025-09
]
},
"KeyUsage": {
"value": [
"decapsulateBits", // No implementation as of 2025-09
"decapsulateKey", // No implementation as of 2025-09
"encapsulateBits", // No implementation as of 2025-09
"encapsulateKey" // No implementation as of 2025-09
]
},
"MediaSessionAction": {
"value": [
"enterpictureinpicture", // Blink only as of 2024-07
Expand Down Expand Up @@ -234,21 +218,6 @@
}
}
},
"CredentialRequestOptions": {
"members": {
"member": {
// Only `mediation`, `publicKey`, `signal` are implemented by 2+ engines, everything else is currently Blink only.
// https://searchfox.org/mozilla-central/source/dom/webidl/CredentialManagement.webidl
// https://searchfox.org/wubkat/source/Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.idl
// https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/credentialmanagement/credential_request_options.idl
"digital": null, // Behind a flag in WebKit and Blink as of 2024-03
"federated": null,
"identity": null,
"otp": null,
"password": null
}
}
},
"DisplayMediaStreamOptions": {
"members": {
"member": {
Expand Down Expand Up @@ -322,14 +291,6 @@
}
}
},
"JsonWebKey": {
"members": {
"member": {
"priv": null, // No implementation as of 2025-09
"pub": null // No implementation as of 2025-09
}
}
},
"KeyframeAnimationOptions": {
"members": {
"member": {
Expand All @@ -338,13 +299,6 @@
}
}
},
"KeySystemTrackConfiguration": {
"members": {
"member": {
"encryptionScheme": null // Gecko only as of 2025-05
}
}
},
"MediaCapabilitiesDecodingInfo": {
"members": {
"member": {
Expand Down Expand Up @@ -453,28 +407,6 @@
}
}
},
"PublicKeyCredentialCreationOptions": {
"members": {
"member": {
"attestationFormats": null, // Blink only as of 2024-08
"hints": null // Blink only as of 2024-08
}
}
},
"PublicKeyCredentialCreationOptionsJSON": {
"members": {
"member": {
"attestationFormats": null // Gecko only as of 2024-08
}
}
},
"PublicKeyCredentialRequestOptions": {
"members": {
"member": {
"hints": null // Blink only as of 2024-08
}
}
},
"PushEventInit": {
"members": {
"member": {
Expand Down