Skip to content

feat: add print query to the website #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a0m0rajab wants to merge 5 commits into
base: v2
Choose a base branch
from
Open

feat: add print query to the website #3205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a56b81a
feat: add print media query
a0m0rajab Aug 17, 2024
3bccabc
chore: remove colour from globals
a0m0rajab Aug 19, 2024
1273282
chore: remove breaks and use avoid for printing
a0m0rajab Oct 17, 2024
7300c60
chore: hide do you like this page
a0m0rajab Feb 17, 2025
f5e1deb
chore: prevent side bar from showing on printed pages
a0m0rajab Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/typescriptlang-org/src/components/handbook/Contributors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const Contributors = (props: ContributorsProps) => {
}, []);

return (
<div className="whitespace-tight raised" style={{ padding: 0 }}>
<div className="whitespace-tight raised no-print" style={{ padding: 0 }}>
<Row className="justify-between small-columns">
<Section sKey="pr">
<p>
Expand Down
2 changes: 1 addition & 1 deletion packages/typescriptlang-org/src/components/handbook/NextPrev.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const NextPrev = (props: NextPrevProps) => {
const next = props.next && props.next.childMarkdownRemark.frontmatter

return (
<div className="whitespace-tight raised">
<div className="whitespace-tight raised no-print">
<Row className="justify-between">
{!prev ? <EmptyLink /> : <LinkSection i={props.i} data={prev} InltLink={props.IntlLink} type="prev" />}
<div className="hide-small vertical-line" />
Expand Down
2 changes: 1 addition & 1 deletion packages/typescriptlang-org/src/components/layout/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export const Sidebar = (props: Props) => {
}

return (
<nav id="sidebar">
<nav id="sidebar" className="np-print">
<ul>
{props.navItems.map(item => <RenderItem key={item.id} item={item} openAllSectionsExceptWhatsNew={props.openAllSectionsExceptWhatsNew} selectedID={props.selectedID} />)}
</ul>
Expand Down
2 changes: 1 addition & 1 deletion packages/typescriptlang-org/src/components/layout/SiteFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export const SiteFooter = (props: Props) => {
const hideDocs = props.suppressDocRecommendations
const lang = props.lang
return (
<footer id="site-footer" role="contentinfo">
<footer id="site-footer" role="contentinfo" className="no-print">
{props.suppressCustomization ? null : <Customize />}

{hideDocs ? null :
Expand Down
2 changes: 1 addition & 1 deletion packages/typescriptlang-org/src/components/layout/TopNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ export const SiteNav = (props: Props) => {


return (
<header dir="ltr">
<header dir="ltr" className="no-print">
<a className="skip-to-main" href={props.skipToAnchor || '#site-content'} tabIndex={0}>{i("skip_to_content")}</a>

<div id="top-menu" className="up">
Expand Down
11 changes: 11 additions & 0 deletions packages/typescriptlang-org/src/style/globals.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,14 @@ $z-index-for-search: 100;
$z-index-for-site-nav: 101;
$z-index-for-handbook-nav: 99;
$z-index-for-handbook-nav-button: 100;

// add print media query
@media print {
.no-print, .no-print * {
display: none !important;
}
.code-container {
display: block;
break-inside: avoid;
}
}
2 changes: 1 addition & 1 deletion packages/typescriptlang-org/src/templates/documentation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ const HandbookTemplate: React.FC<Props> = (props) => {
<MarkdownHeadingTree tree={headerListToTree(sidebarHeaders)} className="handbook-on-this-page-section-list" slug={slug} />
</>
}
<div id="like-dislike-subnav">
<div id="like-dislike-subnav" className="no-print">
<h5>{i("handb_like_dislike_title")}</h5>
<div>
<button title="Like this page" id="like-button"><LikeUnfilledSVG /> {i("handb_like_desc")}</button>
Expand Down