Skip to content

Fixing bug: Unsafe HTML constructed from library input #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
navya9singh merged 5 commits into from
Jan 29, 2025
Merged

Fixing bug: Unsafe HTML constructed from library input #3312

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
72f8aab
fixing bug: Unsafe HTML constructed from library input
navya9singh Jan 27, 2025
c507467
adding striptags import
navya9singh Jan 28, 2025
f25c8a1
addresisng comments
navya9singh Jan 29, 2025
39fca3e
removing striptags
navya9singh Jan 29, 2025
9480229
lock file change
navya9singh Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/playground/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,9 @@ export const setupPlayground = (

// Set up the label for the dropdown
const versionButton = document.querySelectorAll("#versions > a").item(0)
versionButton.innerHTML = "v" + sandbox.ts.version + " <span class='caret'/>"
// Adding HTML sanitizer to remove unsafe content.
const striptags = require('striptags');
versionButton.innerHTML = "v" + striptags(sandbox.ts.version) + " <span class='caret'/>"
versionButton.setAttribute("aria-label", `Select version of TypeScript, currently ${sandbox.ts.version}`)

// Add the versions to the dropdown
Expand Down
Loading