Skip to content

Test generic DOM events again#57040

Closed
sandersn wants to merge 1 commit intomicrosoft:mainfrom
sandersn:test-generic-dom-event-again
Closed

Test generic DOM events again#57040
sandersn wants to merge 1 commit intomicrosoft:mainfrom
sandersn:test-generic-dom-event-again

Conversation

@sandersn
Copy link
Member

@sandersn sandersn commented Jan 12, 2024

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 12, 2024
@sandersn
Copy link
Member Author

sandersn commented Jan 12, 2024

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 12, 2024 •
edited
Loading

Heya @sandersn, I've started to run the regular perf test suite on this PR at 682ca9a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 12, 2024 •
edited
Loading

Heya @sandersn, I've started to run the tarball bundle task on this PR at 682ca9a. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 12, 2024 •
edited
Loading

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 682ca9a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 12, 2024 •
edited
Loading

Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at 682ca9a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 12, 2024 •
edited
Loading

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 682ca9a. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 12, 2024 •
edited
Loading

Hey @sandersn, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159486/artifacts?artifactName=tgz&fileId=85F06FC6ADC4052BA56A5C94C26EECE8187329A1946E1FA8647D86796D0212B102&fileName=/typescript-5.4.0-insiders.20240112.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.4.0-pr-57040-6".;

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 12, 2024

@sandersn Here are the results of running the user test suite comparing main and refs/pull/57040/merge:

There were infrastructure failures potentially unrelated to your change:

  • 1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

bluebird

/mnt/ts_downloads/bluebird/tsconfig.json

  • [NEW] error TS2403: Subsequent variable declarations must have the same type. Variable 'event' must be of type 'CustomEvent<any>', but here has type 'Event<EventTarget>'.
    • /mnt/ts_downloads/bluebird/node_modules/bluebird/js/release/debuggability.js(225,17)
  • [NEW] error TS2339: Property 'detail' does not exist on type 'Event<EventTarget>'.
    • /mnt/ts_downloads/bluebird/node_modules/bluebird/js/release/debuggability.js(232,26)
  • [MISSING] error TS2403: Subsequent variable declarations must have the same type. Variable 'event' must be of type 'CustomEvent<any>', but here has type 'Event'.
    • /mnt/ts_downloads/bluebird/node_modules/bluebird/js/release/debuggability.js(225,17)
  • [MISSING] error TS2339: Property 'detail' does not exist on type 'Event'.
    • /mnt/ts_downloads/bluebird/node_modules/bluebird/js/release/debuggability.js(232,26)

puppeteer

packages/browsers/test/src/tsconfig.json

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 12, 2024

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v18.15.0, x64)
Memory used 295,497k (± 0.01%) 305,098k (± 0.01%) +9,601k (+ 3.25%) 305,060k 305,126k p=0.005 n=6
Parse Time 2.65s (± 0.28%) 2.66s (± 0.66%) ~ 2.63s 2.68s p=0.864 n=6
Bind Time 0.82s (± 0.00%) 0.82s (± 0.00%) ~ 0.82s 0.82s p=1.000 n=6
Check Time 8.14s (± 0.31%) 8.35s (± 0.31%) +0.21s (+ 2.60%) 8.32s 8.38s p=0.005 n=6
Emit Time 7.11s (± 0.46%) 7.12s (± 0.52%) ~ 7.06s 7.17s p=0.686 n=6
Total Time 18.72s (± 0.25%) 18.94s (± 0.16%) +0.22s (+ 1.19%) 18.89s 18.97s p=0.005 n=6
Compiler-Unions - node (v18.15.0, x64)
Memory used 191,975k (± 0.55%) 192,500k (± 1.24%) ~ 191,509k 197,362k p=0.574 n=6
Parse Time 1.36s (± 1.00%) 1.35s (± 1.19%) ~ 1.33s 1.37s p=0.154 n=6
Bind Time 0.72s (± 0.00%) 0.72s (± 0.00%) ~ 0.72s 0.72s p=1.000 n=6
Check Time 9.33s (± 0.38%) 9.37s (± 0.20%) ~ 9.35s 9.39s p=0.061 n=6
Emit Time 2.63s (± 0.50%) 2.63s (± 0.76%) ~ 2.61s 2.66s p=0.797 n=6
Total Time 14.05s (± 0.24%) 14.07s (± 0.23%) ~ 14.03s 14.12s p=0.335 n=6
Monaco - node (v18.15.0, x64)
Memory used 347,403k (± 0.01%) 347,406k (± 0.01%) ~ 347,382k 347,430k p=1.000 n=6
Parse Time 2.47s (± 0.33%) 2.47s (± 0.21%) ~ 2.47s 2.48s p=0.140 n=6
Bind Time 0.93s (± 0.56%) 0.93s (± 0.68%) ~ 0.92s 0.94s p=0.386 n=6
Check Time 6.86s (± 0.52%) 6.86s (± 0.34%) ~ 6.82s 6.89s p=0.871 n=6
Emit Time 4.05s (± 0.44%) 4.04s (± 0.35%) ~ 4.02s 4.06s p=0.289 n=6
Total Time 14.30s (± 0.29%) 14.30s (± 0.18%) ~ 14.27s 14.33s p=0.936 n=6
TFS - node (v18.15.0, x64)
Memory used 302,771k (± 0.00%) 302,772k (± 0.01%) ~ 302,754k 302,797k p=1.000 n=6
Parse Time 2.00s (± 1.14%) 2.00s (± 0.88%) ~ 1.98s 2.02s p=0.568 n=6
Bind Time 1.00s (± 1.03%) 1.00s (± 0.98%) ~ 0.99s 1.02s p=0.788 n=6
Check Time 6.31s (± 0.49%) 6.31s (± 0.30%) ~ 6.29s 6.33s p=1.000 n=6
Emit Time 3.58s (± 0.50%) 3.57s (± 0.46%) ~ 3.55s 3.60s p=0.618 n=6
Total Time 12.89s (± 0.22%) 12.88s (± 0.13%) ~ 12.86s 12.91s p=0.516 n=6
material-ui - node (v18.15.0, x64)
Memory used 508,265k (± 0.00%) 519,661k (± 0.01%) +11,396k (+ 2.24%) 519,623k 519,697k p=0.005 n=6
Parse Time 2.58s (± 0.38%) 2.60s (± 0.63%) ~ 2.57s 2.61s p=0.066 n=6
Bind Time 0.99s (± 0.76%) 1.00s (± 0.52%) ~ 0.99s 1.00s p=0.247 n=6
Check Time 17.10s (± 0.39%) 17.28s (± 0.12%) +0.18s (+ 1.04%) 17.25s 17.30s p=0.005 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 20.67s (± 0.30%) 20.88s (± 0.12%) +0.21s (+ 1.00%) 20.85s 20.91s p=0.005 n=6
xstate - node (v18.15.0, x64)
Memory used 512,979k (± 0.01%) 513,370k (± 0.01%) +391k (+ 0.08%) 513,319k 513,451k p=0.005 n=6
Parse Time 3.28s (± 0.16%) 3.28s (± 0.25%) ~ 3.27s 3.29s p=0.929 n=6
Bind Time 1.53s (± 0.34%) 1.54s (± 0.27%) ~ 1.53s 1.54s p=0.112 n=6
Check Time 2.83s (± 0.27%) 2.87s (± 0.61%) +0.03s (+ 1.24%) 2.85s 2.90s p=0.004 n=6
Emit Time 0.07s (± 5.69%) 0.07s (± 0.00%) ~ 0.07s 0.07s p=0.405 n=6
Total Time 7.72s (± 0.23%) 7.75s (± 0.27%) +0.03s (+ 0.39%) 7.73s 7.79s p=0.035 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Angular - node (v18.15.0, x64)
  • Compiler-Unions - node (v18.15.0, x64)
  • Monaco - node (v18.15.0, x64)
  • TFS - node (v18.15.0, x64)
  • material-ui - node (v18.15.0, x64)
  • xstate - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

tsserver

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,343ms (± 0.26%) 2,353ms (± 0.65%) ~ 2,341ms 2,373ms p=0.261 n=6
Req 2 - geterr 5,503ms (± 1.24%) 5,496ms (± 1.12%) ~ 5,439ms 5,577ms p=0.810 n=6
Req 3 - references 322ms (± 0.54%) 325ms (± 1.47%) ~ 321ms 334ms p=0.462 n=6
Req 4 - navto 274ms (± 1.43%) 275ms (± 1.43%) ~ 270ms 279ms p=1.000 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 88ms (± 6.80%) 87ms (± 4.76%) ~ 84ms 92ms p=0.666 n=6
CompilerTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,465ms (± 1.21%) 2,478ms (± 0.63%) ~ 2,461ms 2,501ms p=0.471 n=6
Req 2 - geterr 4,203ms (± 1.86%) 4,131ms (± 1.48%) ~ 4,095ms 4,254ms p=0.228 n=6
Req 3 - references 337ms (± 1.67%) 338ms (± 1.87%) ~ 329ms 344ms p=1.000 n=6
Req 4 - navto 284ms (± 0.29%) 286ms (± 0.75%) +2ms (+ 0.76%) 284ms 290ms p=0.021 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 84ms (± 8.11%) 85ms (± 8.59%) ~ 74ms 90ms p=0.492 n=6
xstateTSServer - node (v18.15.0, x64)
Req 1 - updateOpen 2,604ms (± 0.23%) 2,603ms (± 0.81%) ~ 2,578ms 2,626ms p=1.000 n=6
Req 2 - geterr 1,720ms (± 2.66%) 1,733ms (± 2.01%) ~ 1,680ms 1,764ms p=0.520 n=6
Req 3 - references 116ms (± 9.66%) 120ms (± 9.14%) ~ 105ms 129ms p=0.415 n=6
Req 4 - navto 365ms (± 0.11%) 367ms (± 0.64%) ~ 365ms 371ms p=0.214 n=6
Req 5 - completionInfo count 2,073 (± 0.00%) 2,074 (± 0.00%) +1 (+ 0.05%) 2,074 2,074 p=0.001 n=6
Req 5 - completionInfo 307ms (± 1.94%) 309ms (± 3.07%) ~ 297ms 318ms p=0.629 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • CompilerTSServer - node (v18.15.0, x64)
  • Compiler-UnionsTSServer - node (v18.15.0, x64)
  • xstateTSServer - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

startup

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
tsc-startup - node (v18.15.0, x64)
Execution time 154.51ms (± 0.20%) 154.51ms (± 0.18%) ~ 153.40ms 157.43ms p=0.381 n=600
tsserver-startup - node (v18.15.0, x64)
Execution time 229.70ms (± 0.16%) 229.43ms (± 0.15%) -0.27ms (- 0.12%) 228.06ms 233.03ms p=0.000 n=600
tsserverlibrary-startup - node (v18.15.0, x64)
Execution time 230.93ms (± 0.18%) 230.83ms (± 0.18%) -0.09ms (- 0.04%) 229.16ms 235.11ms p=0.012 n=600
typescript-startup - node (v18.15.0, x64)
Execution time 230.89ms (± 0.17%) 230.87ms (± 0.22%) ~ 229.30ms 240.67ms p=0.072 n=600
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • tsc-startup - node (v18.15.0, x64)
  • tsserver-startup - node (v18.15.0, x64)
  • tsserverlibrary-startup - node (v18.15.0, x64)
  • typescript-startup - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 12, 2024

Hey @sandersn, the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: dygraphs
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/dygraphs/dygraphs-tests.ts
  109:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  125:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  129:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  139:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  233:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  258:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  271:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  284:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  297:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  304:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect

✖ 10 problems (10 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: keymaster
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/keymaster/test/keymaster-test-global.ts
  2:5  error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect

/home/vsts/work/1/DefinitelyTyped/types/keymaster/test/keymaster-tests.ts
  10:5  error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  14:5  error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: simulant
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/simulant/simulant-tests.ts
  3:1  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  4:1  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  6:1  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  7:1  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: zoomist
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/zoomist/zoomist-tests.ts
  52:13  error  TypeScript@local expected type to be:
  (e: Event) => void
got:
  (e: Event<EventTarget>) => void                        @definitelytyped/expect
  56:13  error  TypeScript@local expected type to be:
  (t: {}, e: Event) => void
got:
  (t: {}, e: Event<EventTarget>) => void          @definitelytyped/expect
  61:13  error  TypeScript@local expected type to be:
  (t: {}, e: Event) => void
got:
  (t: {}, e: Event<EventTarget>) => void          @definitelytyped/expect
  66:13  error  TypeScript@local expected type to be:
  (t: {}, e: Event) => void
got:
  (t: {}, e: Event<EventTarget>) => void          @definitelytyped/expect
  71:13  error  TypeScript@local expected type to be:
  (v: number, e: Event) => void
got:
  (v: number, e: Event<EventTarget>) => void  @definitelytyped/expect
  76:13  error  TypeScript@local expected type to be:
  (v: number, e: Event) => void
got:
  (v: number, e: Event<EventTarget>) => void  @definitelytyped/expect
  81:13  error  TypeScript@local expected type to be:
  (v: number, e: Event) => void
got:
  (v: number, e: Event<EventTarget>) => void  @definitelytyped/expect
  86:13  error  TypeScript@local expected type to be:
  (e: Event) => void
got:
  (e: Event<EventTarget>) => void                        @definitelytyped/expect
  90:13  error  TypeScript@local expected type to be:
  (e: Event) => void
got:
  (e: Event<EventTarget>) => void                        @definitelytyped/expect
  94:13  error  TypeScript@local expected type to be:
  (e: Event) => void
got:
  (e: Event<EventTarget>) => void                        @definitelytyped/expect

✖ 10 problems (10 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: jsoneditor
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/jsoneditor/jsoneditor-tests.ts
  236:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  242:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  248:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: nowigence-react-simple-maps
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/nowigence-react-simple-maps/nowigence-react-simple-maps-tests.tsx
  24:17  error  TypeScript@local expected type to be:
  WheelEvent
got:
  WheelEvent<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: rails__ujs
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/rails__ujs/rails__ujs-tests.ts
  42:9  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: page
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/page/page-tests.ts
  111:1  error  TypeScript@local expected type to be:
  (e: MouseEvent) => void
got:
  (e: MouseEvent<EventTarget>) => void  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: reveal.js
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/reveal.js/reveal.js-tests.ts
  689:1  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: amap-js-api-place-search
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/amap-js-api-place-search/amap-js-api-place-search-tests.ts
  412:5  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: jsdom
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/jsdom/jsdom-tests.ts
  24:1  error  TypeScript@local expected type to be:
  InputEvent
got:
  InputEvent<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: cookiebot-sdk
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/cookiebot-sdk/cookiebot-sdk-tests.ts
  28:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  32:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  36:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  40:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  44:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  48:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  52:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect

✖ 7 problems (7 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: raphael
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/raphael/test/raphael-tests-api.ts
   575:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   598:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   625:13  error  TypeScript@local expected type to be:
  DragEvent
got:
  DragEvent<EventTarget>    @definitelytyped/expect
   635:13  error  TypeScript@local expected type to be:
  DragEvent
got:
  DragEvent<EventTarget>    @definitelytyped/expect
   641:13  error  TypeScript@local expected type to be:
  DragEvent
got:
  DragEvent<EventTarget>    @definitelytyped/expect
   746:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   752:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   808:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   826:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   844:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   862:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   880:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1006:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1024:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1042:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1060:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1086:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1104:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1126:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1132:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1174:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1192:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1210:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1228:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1246:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1264:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1282:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1300:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1318:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect

✖ 29 problems (29 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: yaireo__tagify
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/yaireo__tagify/yaireo__tagify-tests.ts
   78:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>        @definitelytyped/expect
  141:13  error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  211:13  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>                  @definitelytyped/expect
  217:13  error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  653:5   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>        @definitelytyped/expect
  659:5   error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  665:5   error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  701:5   error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>                  @definitelytyped/expect
  849:5   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>        @definitelytyped/expect
  855:5   error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  861:5   error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  897:5   error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>                  @definitelytyped/expect

✖ 12 problems (12 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: react-simple-maps
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/react-simple-maps/react-simple-maps-tests.tsx
  24:17  error  TypeScript@local expected type to be:
  WheelEvent
got:
  WheelEvent<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.1.3_typescript@5.4.0-dev.20240112/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

You can check the log here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 12, 2024

@sandersn Here are the results of running the top-repos suite comparing main and refs/pull/57040/merge:

Something interesting changed - please have a look.

Details

chakra-ui/chakra-ui

4 of 28 projects failed to build with the old tsc and were ignored

packages/components/tsconfig.build.json

  • error TS5056: Cannot write file '/mnt/ts_downloads/chakra-ui/packages/components/dist/types/menu/menu.stories.d.ts' because it would be overwritten by multiple input files.
    • Project Scope

pixijs/pixijs

tsconfig.json

tsconfig.types.json

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

  • error TS2320: Interface 'CompositionEvent<T>' cannot simultaneously extend types 'UIEvent<T>' and 'Event<EventTarget>'.
  • error TS2320: Interface 'DragEvent<T>' cannot simultaneously extend types 'MouseEvent<T>' and 'Event<EventTarget>'.
  • error TS2320: Interface 'FocusEvent<T>' cannot simultaneously extend types 'UIEvent<T>' and 'Event<EventTarget>'.
  • error TS2320: Interface 'KeyboardEvent<T>' cannot simultaneously extend types 'UIEvent<T>' and 'Event<EventTarget>'.
  • error TS2320: Interface 'MouseEvent<T>' cannot simultaneously extend types 'UIEvent<T>' and 'Event<EventTarget>'.
  • error TS2320: Interface 'PointerEvent<T>' cannot simultaneously extend types 'MouseEvent<T>' and 'Event<EventTarget>'.
  • error TS2320: Interface 'TouchEvent<T>' cannot simultaneously extend types 'UIEvent<T>' and 'Event<EventTarget>'.
  • error TS2320: Interface 'UIEvent<T>' cannot simultaneously extend types 'Event<T>' and 'Event<EventTarget>'.
  • error TS2320: Interface 'WheelEvent<T>' cannot simultaneously extend types 'MouseEvent<T>' and 'Event<EventTarget>'.

@sandersn sandersn added the Experiment A fork with an experimental idea which might not make it into master label Jan 30, 2024
@sandersn
Copy link
Member Author

sandersn commented Apr 1, 2025

This experimental branch is unused so I'm closing it.

@sandersn sandersn closed this Apr 1, 2025
@github-project-automation github-project-automation bot moved this from Waiting on author to Done in PR Backlog Apr 1, 2025
@sandersn sandersn removed this from PR Backlog Apr 22, 2025
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@sandersn sandersn

Labels

Author: Team Experiment A fork with an experimental idea which might not make it into master For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sandersn @typescript-bot