Fix private properties not being allowed in optional chains #60263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Milestone Bug
Contributor
Author
|
@microsoft-github-policy-service agree |
Psychpsyo
changed the title
jakebailey
requested changes
Jun 30, 2025
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
Coming back to this, this PR is missing a few things that would make this work:
- A test that the downlevelling works, so set the test's target to
@target: esnext,es2015. - A new test that verifies some sort of cross-class error happens, e.g. copy and paste the class in the test to
B, and there should be type errors sinceAis the wrong class.
github-project-automation
bot
moved this from Not started
to Waiting on author
in PR Backlog
Contributor
Author
Done that now. |
jakebailey
reviewed
Sep 30, 2025
Comment on lines
-6408
to
-6410
| if (isOptionalChain && isPrivateIdentifier(propertyAccess.name)) { | ||
| parseErrorAtRange(propertyAccess.name, Diagnostics.An_optional_chain_cannot_contain_private_identifiers); | ||
| } |
Member
There was a problem hiding this comment.
I suspect we need sort of version check to verify that the syntax is available to the syntax we're emitting, like a new grammar check in the checker to verify this.
Unless you're saying that this syntax has always been allowed since feature was standardized?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42734
This makes it so that expressions of the form
foo?.#barorfoo?.bar.#bazare no longer seen as invalid, since the relevant JavaScript standards allow these by now and TypeScript claims to be a superset of JavaScript.Specifically, private properties are now allowed inside an optional chain.
This syntax is allowed since tc39/proposal-class-fields#301
The added
this.a = this;inprivateIdentifierChain.1.tsis there so that line 14,this?.a.#b;, does not error becauseamight be undefined, as that's not what this file is testing for.I'm sorry for fixing an issue that is not in the backlog, but this is bothering me personally and has existed for years at this point.
Otherwise, I have verified that:
mainbranchhereby runtestslocally