Skip to content

Fix a crash in an anonymous buffer that copilot is writing to. #60377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sandersn merged 1 commit into from
Oct 30, 2024
Merged

Fix a crash in an anonymous buffer that copilot is writing to. #60377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/server/scriptVersionCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,6 +632,7 @@ export class LineNode implements LineCollection {

walk(rangeStart: number, rangeLength: number, walkFns: LineIndexWalker): void {
// assume (rangeStart < this.totalChars) && (rangeLength <= this.totalChars)
if (this.children.length === 0) return;
Copy link
Member

@iisaduan iisaduan Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this.children always defined?

Copy link
Member Author

@sandersn sandersn Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the type is LineCollection[] and the constructor defaults it to [] if it's not provided.

Edit: in fact, there are no explicit assignments to it; just the implicit private readonly children: LineCollection[] = [] in the constructor.

let childIndex = 0;
let childCharCount = this.children[childIndex].charCount();
// find sub-tree containing start
Expand Down