Use contextual type of the left operand for the right one in assignments to auto-typed class fields #60395

Andarist · 2024-11-03T12:03:00Z

…nts to auto-typed class fields

jakebailey · 2024-11-04T19:07:14Z

typescript-bot · 2024-11-04T19:07:18Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-11-04T20:02:32Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-11-04T20:07:28Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₁	₃₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,379	_50,379	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,412k (± 0.76%)}	_{192,857k (± 0.07%)}	_~	_192,773k	_193,141k	_{p=0.810 n=6}
_{Parse Time}	_{1.32s (± 0.62%)}	_{1.32s (± 0.75%)}	_~	_1.30s	_1.33s	_{p=0.673 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.74s (± 0.15%)}	_{9.74s (± 0.43%)}	_~	_9.70s	_9.82s	_{p=0.454 n=6}
_{Emit Time}	_{2.72s (± 0.36%)}	_{2.71s (± 0.39%)}	_~	_2.70s	_2.73s	_{p=0.315 n=6}
_{Total Time}	_{14.50s (± 0.17%)}	_{14.50s (± 0.23%)}	_~	_14.47s	_14.56s	_{p=0.513 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,888	_947,888	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,840	_410,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,795k (± 0.00%)}	_{1,224,839k (± 0.00%)}	_~	_1,224,778k	_1,224,889k	_{p=0.128 n=6}
_{Parse Time}	_{8.10s (± 0.60%)}	_{8.04s (± 1.04%)}	_~	_7.95s	_8.13s	_{p=0.166 n=6}
_{Bind Time}	_{2.27s (± 0.87%)}	_{2.26s (± 0.97%)}	_~	_2.23s	_2.29s	_{p=0.280 n=6}
_{Check Time}	_{37.74s (± 0.25%)}	_{37.89s (± 0.51%)}	_~	_37.69s	_38.17s	_{p=0.229 n=6}
_{Emit Time}	_{18.20s (± 0.22%)}	_{18.19s (± 0.55%)}	_~	_18.09s	_18.35s	_{p=0.575 n=6}
_{Total Time}	_{66.32s (± 0.12%)}	_{66.37s (± 0.32%)}	_~	_66.02s	_66.55s	_{p=0.378 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,495,004	_2,495,004	_~	_~	_~	_{p=1.000 n=6}
_Types	_908,592	_908,592	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,307,568k (± 0.00%)}	_{2,307,490k (± 0.01%)}	_~	_2,307,223k	_2,307,655k	_{p=0.689 n=6}
_{Parse Time}	_{11.22s (± 0.40%)}	_{11.17s (± 0.54%)}	_~	_11.08s	_11.23s	_{p=0.199 n=6}
_{Bind Time}	_{2.63s (± 1.02%)}	_{2.63s (± 0.56%)}	_~	_2.61s	_2.65s	_{p=0.569 n=6}
_{Check Time}	_{90.10s (± 0.89%)}	_{91.39s (± 2.35%)}	_~	_89.16s	_94.59s	_{p=0.378 n=6}
_{Emit Time}	_{0.34s (± 1.59%)}	_{0.35s (± 2.35%)}	_~	_0.34s	_0.36s	_{p=0.859 n=6}
_{Total Time}	_{104.29s (± 0.78%)}	_{105.53s (± 2.01%)}	_~	_103.27s	_108.67s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,544	_1,258,552	_{+8 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,358	_266,360	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,147,938k (± 0.03%)}	_{3,028,391k (± 9.73%)}	_~	_2,426,003k	_3,149,562k	_{p=0.378 n=6}
_{Parse Time}	_{6.64s (± 0.78%)}	_{6.60s (± 1.47%)}	_~	_6.45s	_6.72s	_{p=0.521 n=6}
_{Bind Time}	_{2.29s (± 4.91%)}	_{2.31s (± 5.45%)}	_~	_2.07s	_2.41s	_{p=0.378 n=6}
_{Check Time}	_{43.15s (± 0.36%)}	_{42.93s (± 0.39%)}	_{-0.21s (- 0.49%)}	_42.71s	_43.13s	_{p=0.031 n=6}
_{Emit Time}	_{3.50s (± 2.08%)}	_{3.50s (± 2.17%)}	_~	_3.39s	_3.59s	_{p=1.000 n=6}
_{Total Time}	_{55.57s (± 0.22%)}	_{55.35s (± 0.42%)}	_~	_55.06s	_55.63s	_{p=0.128 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,258,544	_1,258,552	_{+8 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,358	_266,360	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,981,829k (±12.38%)}	_{2,740,454k (±13.55%)}	_~	_2,499,656k	_3,220,685k	_{p=0.128 n=6}
_{Parse Time}	_{6.76s (± 2.10%)}	_{6.64s (± 2.22%)}	_~	_6.51s	_6.85s	_{p=0.149 n=6}
_{Bind Time}	_{2.22s (± 5.02%)}	_{2.15s (± 1.69%)}	_~	_2.09s	_2.20s	_{p=0.230 n=6}
_{Check Time}	_{43.21s (± 0.28%)}	_{43.21s (± 0.43%)}	_~	_43.04s	_43.55s	_{p=0.689 n=6}
_{Emit Time}	_{3.53s (± 1.72%)}	_{3.52s (± 2.03%)}	_~	_3.42s	_3.64s	_{p=1.000 n=6}
_{Total Time}	_{55.73s (± 0.47%)}	_{55.52s (± 0.45%)}	_~	_55.28s	_55.89s	_{p=0.128 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_261,751	_261,757	_{+6 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,472	_106,473	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{438,566k (± 0.01%)}	_{438,645k (± 0.01%)}	_~	_438,580k	_438,737k	_{p=0.066 n=6}
_{Parse Time}	_{2.88s (± 0.56%)}	_{2.89s (± 0.57%)}	_~	_2.87s	_2.91s	_{p=0.623 n=6}
_{Bind Time}	_1.10s	_{1.10s (± 0.37%)}	_~	_1.10s	_1.11s	_{p=0.405 n=6}
_{Check Time}	_{15.69s (± 0.29%)}	_{15.73s (± 0.32%)}	_~	_15.67s	_15.81s	_{p=0.198 n=6}
_{Emit Time}	_{1.30s (± 0.79%)}	_{1.30s (± 1.49%)}	_~	_1.28s	_1.33s	_{p=1.000 n=6}
_{Total Time}	_{20.97s (± 0.17%)}	_{21.01s (± 0.28%)}	_~	_20.96s	_21.09s	_{p=0.226 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,921	_225,921	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,415	_94,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,091k (± 0.03%)}	_{371,046k (± 0.02%)}	_~	_370,943k	_371,104k	_{p=0.810 n=6}
_{Parse Time}	_{2.31s (± 0.71%)}	_{2.31s (± 0.76%)}	_~	_2.30s	_2.35s	_{p=0.669 n=6}
_{Bind Time}	_{1.32s (± 0.68%)}	_{1.32s (± 0.31%)}	_~	_1.31s	_1.32s	_{p=0.787 n=6}
_{Check Time}	_{13.61s (± 0.53%)}	_{13.63s (± 0.46%)}	_~	_13.57s	_13.74s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{17.25s (± 0.46%)}	_{17.26s (± 0.44%)}	_~	_17.19s	_17.40s	_{p=0.748 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₁₄	_{🔻+11 (+366.67%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_3,132,118	_3,132,242	_{+124 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_1,079,618	_1,079,661	_{+43 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,220,955k (± 0.00%)}	_{3,220,982k (± 0.01%)}	_~	_3,220,262k	_3,221,274k	_{p=0.230 n=6}
_{Parse Time}	_{11.58s (± 0.14%)}	_{11.57s (± 0.31%)}	_~	_11.52s	_11.62s	_{p=0.467 n=6}
_{Bind Time}	_{3.70s (± 0.50%)}	_{3.72s (± 0.55%)}	_~	_3.69s	_3.75s	_{p=0.118 n=6}
_{Check Time}	_{71.94s (± 0.34%)}	_{72.31s (± 0.43%)}	_{+0.38s (+ 0.53%)}	_72.04s	_72.90s	_{p=0.037 n=6}
_{Emit Time}	_{22.79s (± 0.29%)}	_{22.89s (± 0.39%)}	_{+0.10s (+ 0.43%)}	_22.79s	_23.04s	_{p=0.045 n=6}
_{Total Time}	_{110.01s (± 0.23%)}	_{110.48s (± 0.32%)}	_{+0.48s (+ 0.43%)}	_110.07s	_111.09s	_{p=0.031 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_288,119	_288,119	_~	_~	_~	_{p=1.000 n=6}
_Types	_116,928	_116,928	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{439,502k (± 0.02%)}	_{439,457k (± 0.02%)}	_~	_439,355k	_439,586k	_{p=0.423 n=6}
_{Parse Time}	_{4.05s (± 0.73%)}	_{4.08s (± 0.70%)}	_~	_4.05s	_4.11s	_{p=0.063 n=6}
_{Bind Time}	_{1.73s (± 0.67%)}	_{1.75s (± 1.24%)}	_~	_1.72s	_1.78s	_{p=0.288 n=6}
_{Check Time}	_{18.63s (± 0.56%)}	_{18.66s (± 0.53%)}	_~	_18.52s	_18.77s	_{p=0.575 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{24.41s (± 0.44%)}	_{24.49s (± 0.35%)}	_~	_24.37s	_24.59s	_{p=0.199 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_543,132	_543,132	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,889	_181,889	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{485,555k (± 0.01%)}	_{485,556k (± 0.01%)}	_~	_485,516k	_485,588k	_{p=0.630 n=6}
_{Parse Time}	_{3.37s (± 0.60%)}	_{3.38s (± 0.31%)}	_~	_3.37s	_3.40s	_{p=0.253 n=6}
_{Bind Time}	_{1.18s (± 1.46%)}	_{1.18s (± 1.03%)}	_~	_1.16s	_1.19s	_{p=0.806 n=6}
_{Check Time}	_{19.20s (± 0.32%)}	_{19.17s (± 0.36%)}	_~	_19.05s	_19.24s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{23.76s (± 0.19%)}	_{23.74s (± 0.27%)}	_~	_23.63s	_23.81s	_{p=0.572 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-11-04T20:07:39Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60395/merge:

Something interesting changed - please have a look.

Details

puppeteer

packages/puppeteer-core/tsconfig.json

[NEW] error TS2322: Type '(node: never, selector: never, PuppeteerUtil: never) => Promise<Node | null>' is not assignable to type 'QuerySelector'.
[NEW] error TS2322: Type '(node: never, selector: never, PuppeteerUtil: never) => AsyncGenerator<Node, void, unknown>' is not assignable to type 'QuerySelectorAll'.

typescript-bot · 2024-11-04T21:29:41Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60395/merge:

Something interesting changed - please have a look.

Details

adonisjs/core

tsconfig.json

error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
- commands/make/middleware.ts#L53
error TS2345: Argument of type '"server" | "router" | "named" | undefined' is not assignable to parameter of type '"server" | "router" | "named"'.
- commands/make/middleware.ts#L87

GrapesJS/grapesjs

1 of 3 projects failed to build with the old tsc and were ignored

packages/core/tsconfig.json

error TS2740: Type 'Element' is missing the following properties from type 'HTMLElement': accessKey, accessKeyLabel, autocapitalize, dir, and 126 more.
error TS2532: Object is possibly 'undefined'.
error TS2322: Type 'Element | null' is not assignable to type 'HTMLInputElement | null | undefined'.
- packages/core/src/asset_manager/view/AssetsView.ts#L102
error TS18048: 'inputEl' is possibly 'undefined'.
error TS18048: 'prvEl' is possibly 'undefined'.
- packages/core/src/style_manager/view/LayerView.ts#L110
error TS18048: 'wrapEl' is possibly 'undefined'.
- packages/core/src/style_manager/view/LayerView.ts#L118
- packages/core/src/style_manager/view/LayerView.ts#L120
error TS2740: Type 'Element' is missing the following properties from type 'HTMLInputElement': accept, align, alt, autocomplete, and 185 more.
- packages/core/src/style_manager/view/PropertySliderView.ts#L27

microsoft/vscode

5 of 53 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2741: Property 'align' is missing in type 'HTMLElement' but required in type 'HTMLDivElement'.
- src/vs/editor/contrib/peekView/browser/peekView.ts#L184
error TS2532: Object is possibly 'undefined'.
- src/vs/editor/contrib/peekView/browser/peekView.ts#L186
error TS2769: No overload matches this call.
- src/vs/editor/contrib/peekView/browser/peekView.ts#L187
- src/vs/editor/contrib/peekView/browser/peekView.ts#L189
error TS7006: Parameter 'event' implicitly has an 'any' type.
- src/vs/editor/contrib/peekView/browser/peekView.ts#L187
error TS2345: Argument of type 'HTMLDivElement | undefined' is not assignable to parameter of type 'HTMLElement'.
- src/vs/editor/contrib/peekView/browser/peekView.ts#L191
- src/vs/editor/contrib/peekView/browser/peekView.ts#L195
error TS2322: Type 'CommentReply<IRange | ICellRange>' is not assignable to type 'CommentReply<T>'.
- src/vs/workbench/contrib/comments/browser/commentThreadWidget.ts#L291
error TS2345: Argument of type 'CommentReply<T> | undefined' is not assignable to parameter of type 'IDisposable'.
- src/vs/workbench/contrib/comments/browser/commentThreadWidget.ts#L307
error TS2322: Type 'CommentThreadAdditionalActions<IRange | ICellRange>' is not assignable to type 'CommentThreadAdditionalActions<T>'.
- src/vs/workbench/contrib/comments/browser/commentThreadWidget.ts#L311
error TS2345: Argument of type 'CommentThreadAdditionalActions<T> | undefined' is not assignable to parameter of type 'IDisposable'.
- src/vs/workbench/contrib/comments/browser/commentThreadWidget.ts#L320

src/tsconfig.monaco.json

error TS2741: Property 'align' is missing in type 'HTMLElement' but required in type 'HTMLDivElement'.
- src/vs/editor/contrib/peekView/browser/peekView.ts#L184
error TS2532: Object is possibly 'undefined'.
- src/vs/editor/contrib/peekView/browser/peekView.ts#L186
error TS2769: No overload matches this call.
- src/vs/editor/contrib/peekView/browser/peekView.ts#L187
- src/vs/editor/contrib/peekView/browser/peekView.ts#L189
error TS7006: Parameter 'event' implicitly has an 'any' type.
- src/vs/editor/contrib/peekView/browser/peekView.ts#L187
error TS2345: Argument of type 'HTMLDivElement | undefined' is not assignable to parameter of type 'HTMLElement'.
- src/vs/editor/contrib/peekView/browser/peekView.ts#L191
- src/vs/editor/contrib/peekView/browser/peekView.ts#L195

…or-assignments-on-this-property-with-auto-types

Andarist · 2024-11-30T17:59:00Z

@jakebailey I fixed a small regression that has been caught above, could you rerun the tests? :)

Use contextual type of the left operand for the right one in assignme…

554be1f

…nts to auto-typed class fields

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Nov 3, 2024

fixed spurious circularity errors related to static blocks

282d20a

Andarist marked this pull request as ready for review November 4, 2024 11:12

Andarist added 3 commits November 4, 2024 12:13

fix comment

96fe0a7

tweak code

7e5bf5f

fixed IIFEs

19d3e63

Andarist added 2 commits November 30, 2024 17:10

Merge remote-tracking branch 'origin/main' into fix/contextual-type-f…

1f58d01

…or-assignments-on-this-property-with-auto-types

fixed regression related to optional class fields

3e4b06f

typescript-bot added For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 30, 2024

Andarist added 2 commits November 30, 2024 20:28

correct auto container lookup

db429aa

actually fix it fix it

c1a8439

Use contextual type of the left operand for the right one in assignments to auto-typed class fields #60395

Are you sure you want to change the base?

Use contextual type of the left operand for the right one in assignments to auto-typed class fields #60395

Uh oh!

Conversation

Andarist commented Nov 3, 2024

Uh oh!

jakebailey commented Nov 4, 2024

Uh oh!

typescript-bot commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Nov 4, 2024

Uh oh!

typescript-bot commented Nov 4, 2024

tsc

Uh oh!

typescript-bot commented Nov 4, 2024

Uh oh!

typescript-bot commented Nov 4, 2024

Uh oh!

Andarist commented Nov 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Nov 4, 2024 •

edited

Loading