Skip to content

Fixed a printer crash caused by empty parameter modifiers #60537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 2 commits into from
Jun 30, 2025
Merged

Fixed a printer crash caused by empty parameter modifiers #60537

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1d4f39
Fixed a printer crash caused by empty parameter modifiers
Andarist Nov 19, 2024
0d3a172
just use `undefined`
Andarist Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiler/expressionToTypeNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,7 +1114,7 @@ export function createSyntacticTypeNodeBuilder(
function ensureParameter(p: ParameterDeclaration, context: SyntacticTypeNodeBuilderContext) {
return factory.updateParameterDeclaration(
p,
[],
p.modifiers,
reuseNode(context, p.dotDotDotToken),
resolver.serializeNameOfParameter(context, p),
resolver.isOptionalParameter(p) ? factory.createToken(SyntaxKind.QuestionToken) : undefined,
Expand Down
31 changes: 31 additions & 0 deletions tests/cases/fourslash/completionEntryClassMembersWithInferredFunctionReturnType1.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
///<reference path="fourslash.ts" />

// @filename: /tokenizer.ts
//// export default abstract class Tokenizer {
//// errorBuilder() {
//// return (pos: number, lineStart: number, curLine: number) => {};
//// }
//// }

// @filename: /expression.ts
//// import Tokenizer from "./tokenizer.js";
////
//// export default abstract class ExpressionParser extends Tokenizer {
//// /**/
//// }

verify.completions({
marker: "",
includes: [
{
name: "errorBuilder",
insertText: "errorBuilder(): (pos: number, lineStart: number, curLine: number) => void {\n}",
filterText: "errorBuilder",
},
],
preferences: {
includeCompletionsWithInsertText: true,
includeCompletionsWithClassMemberSnippets: true,
},
isNewIdentifierLocation: true,
});