Skip to content

Conversation

@Ratiranjan5
Copy link

@Ratiranjan5 Ratiranjan5 commented Dec 19, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary
  • Fixed issue 'undeclared-identifier' for pngcrush.
Build/Dependency Packages

Please Build the following packages to build pngcrush:
python-webencodings libsamplerate python-rdflib python-sphinxygen v4l-utils cdparanoia graphene libogg libtheora libvisual libvorbis lv2 fftw serd sord sound-theme-freedesktop sratom zix cldr-emoji-annotation iso-codes libasyncns libcanberra libdbusmenu gstreamer1 gstreamer1-plugins-base speexdsp webrtc-audio-processing rtkit unicode-emoji unicode-ucd sbc lilv orc docbook-style-dsssl openjade perl-SGMLSpm elinks gpm linuxconsoletools ibus pipewire pulseaudio SDL2 docbook-utils

Change Log
  • new file: SPECS-EXTENDED/pngcrush/pngcrush-1.8.13-fix-undeclared-identifier.patch
  • modified: SPECS-EXTENDED/pngcrush/pngcrush.spec
Does this affect the toolchain?

NO

Test Methodology
image
  • Failed SRPM test fail:
image

-Installation Check:

image

-Uninstallation Check:

image
  • Pipeline build id: xxxx

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 19, 2025
@sandeepkarambelkar
Copy link
Contributor

@Ratiranjan5
Copy link
Author

Hi,
Updated the dependency package list by adding 'python‑webencodings'.
Verified installation and uninstallation successfully on the AZL 3.0 Docker image.
This PR is now ready for buddy build and review.
Thank you.

@sandeepkarambelkar
Copy link
Contributor

@sandeepkarambelkar
Copy link
Contributor

@Ratiranjan5
Copy link
Author

Ratiranjan5 commented Dec 30, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1014605&view=results

The Buddy Build has failed during the SRPM test for the pulseaudio package and reported license check warnings for some packages.

Please find the attached SS highlighting the failed SRPM test for the pulseaudio package:

SS_pulseaudio-testfail-SS-2025-12-30 SS_pulseaudio-testfail-2025-12-30

The license check warnings are related to the packages docbook-utils, fftw-doc, perl-SGMLSpm, unicode-ucd, ibus, libasyncns, libcanberra, libogg, libsamplerate-devel, libtheora-devel, openjade, and rtkit, which are not related to the pngcrush package.

Please find the attached SS:

SS_pngcrush-LicenseCheck-2025-12-30

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 31, 2025

@Ratiranjan5 , What is the reason of test failures?
Install tests are failing due to test failures. Can you try to address and fix the test failure of pulseaudio in the same PR?

@Ratiranjan5
Copy link
Author

@Ratiranjan5 , What is the reason of test failures? Install tests are failing due to test failures. Can you try to address and fix the test failure of pulseaudio in the same PR?

The Failing test is cpu-volume-test

Attached the SS:

SS_pulseaudio-TestCaseFail-2025-12-31

@sandeepkarambelkar
Copy link
Contributor

It would be interesting to understand reason for failure since its segfault. However that out of scope of this PR. I would suggest to update the manual install results for this package from the RPMs built in the buddy build and update the results. Lets proceed further with this PR.

We need to check the pulseaudio test failure separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants