-
Notifications
You must be signed in to change notification settings - Fork 602
Upgrade perl-PkgConfig-LibPkgConf to 0.11-24 #15358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0-dev
Are you sure you want to change the base?
Upgrade perl-PkgConfig-LibPkgConf to 0.11-24 #15358
Conversation
a818e4e to
45d4164
Compare
|
Hi, This is a standalone package, tested installation and uninstallations successfully in docker 3.0 image. |
|
@durgajagadeesh Buddy Build have test failures. Can you check them? |
|
Buddy Build to check dependent package (perl-Alien-Build) status with this package - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011058&view=results |
Hi @sandeepkarambelkar, I was working on this package to resolve test failures. Thank you. |
I was found this issue with libpkgconf version. |
The tests are failing during the Upgrade because of a version mismatch in libpkgconf. The upstream Perl module PkgConfig::LibPkgConf 0.11 was designed for libpkgconf 1.x, but our CBL-mariner uses libpkgconf 2.x. The tests in PkgConfig-LibPkgConf-0.11.tar.gz assume libpkgconf 1.x ordering semantics, while libpkgconf 2.x (used in CBL-mariner) behaves differently. libpkgconf 2.x returns paths in a different order compared to libpkgconf 1.x, With libpkgconf 2.x (2.0.2 on Mariner), the internal ordering has changed for: search paths `Tests in t/client.t hardcode the expected ordering, so the module’s output does not match anymore. Example mismatch(debug message from log): Failed test at t/client.t line 220.: time="2025-12-25T06:43:13Z" level=debug msg=" # Structures begin differing at:" time="2025-12-25T06:43:13Z" level=debug msg=" # $got->[0] = '/tmp/LzQo2YxNiG/bar'" time="2025-12-25T06:43:13Z" level=debug msg=" # $expected->[0] = '/tmp/LzQo2YxNiG/foo'" Failed test at t/client.t line 223.: time="2025-12-25T06:43:13Z" level=debug msg=" # Structures begin differing at:" time="2025-12-25T06:43:13Z" level=debug msg=" # $got->[0] = '/tmp/LzQo2YxNiG/formers'" time="2025-12-25T06:43:13Z" level=debug msg=" # $expected->[0] = '/tmp/LzQo2YxNiG/trans'" Note: this version change only impacts tests and doesn't impact functionality of the RPM. |
|
|
Hi @sandeepkarambelkar, I have disabled the only failing test because of the Tests in t/client.t hardcode the expected ordering, so the module’s output does not match anymore. Note: these changes only impacts tests and doesn't impact functionality of the RPM. |
|
Buddy Build after latest changes - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1015511&view=results |
| Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) | ||
| %endif | ||
| Requires: perl(Carp) | ||
| Requires: libpkgconf > 2.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we provide libpkgconf 2.1.0 version. Our version is 2.0.2
https://packages.microsoft.com/azurelinux/3.0/prod/base/x86_64/Packages/l/libpkgconf-2.0.2-1.azl3.x86_64.rpm
Can you correct the version and test the build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sandeepkarambelkar, I have incorporated my changes and tested to the resolve this error.
Please let me know if there is any changes has to be update.
-Thank you!
sandeepkarambelkar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buddy Build install test failed with error -
Installing perl-PkgConfig-LibPkgConf
Loaded plugin: tdnfrepogpgcheck
- nothing provides libpkgconf > 2.1.0 needed by perl-PkgConfig-LibPkgConf-0.11-24.azl3.x86_64
Need to compile with 2.0.2 version
Hi @sandeepkarambelkar, I have incorporated my changes to the resolve this error. b) Installation:
|





Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Upgrade perl-PkgConfig-LibPkgConf to 0.11-24
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology