Skip to content

Conversation

@durgajagadeesh
Copy link
Contributor

@durgajagadeesh durgajagadeesh commented Dec 22, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Upgrade perl-PkgConfig-LibPkgConf to 0.11-24

Change Log
  • Modified file: perl-PkgConfig-LibPkgConf.spec
  • New file: PkgConfig-LibPkgConf-0.11-adapt_to_pkgconf_1.9.4.patch
  • New file: PkgConfig-LibPkgConf-0.11-Fix-resolving-flags-for-packages-with-a-name-differe.patch
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology
  • Build Summary:
image
  • Installation:
image
  • Uninstallation:
image

@durgajagadeesh durgajagadeesh requested a review from a team as a code owner December 22, 2025 10:38
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 22, 2025
@durgajagadeesh durgajagadeesh marked this pull request as draft December 22, 2025 10:41
@durgajagadeesh durgajagadeesh force-pushed the topic_perl-PkgConfig-LibPkgConf branch from a818e4e to 45d4164 Compare December 22, 2025 11:47
@durgajagadeesh durgajagadeesh marked this pull request as ready for review December 22, 2025 11:54
@durgajagadeesh
Copy link
Contributor Author

Hi, This is a standalone package, tested installation and uninstallations successfully in docker 3.0 image.
And this PR is ready for buddy build and review.
-Thank you!

@sandeepkarambelkar
Copy link
Contributor

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1010273&view=results

@sandeepkarambelkar
Copy link
Contributor

@durgajagadeesh Buddy Build have test failures. Can you check them?

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1010273&view=logs&j=bac295d9-f2e0-5165-e63e-e76f383e1a27&t=859205e3-cba0-55b5-b3f1-35d1c4f611a6

@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 23, 2025

Buddy Build to check dependent package (perl-Alien-Build) status with this package - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1011058&view=results

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Dec 24, 2025

@durgajagadeesh Buddy Build have test failures. Can you check them?

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1010273&view=logs&j=bac295d9-f2e0-5165-e63e-e76f383e1a27&t=859205e3-cba0-55b5-b3f1-35d1c4f611a6

Hi @sandeepkarambelkar, I was working on this package to resolve test failures.
image

Thank you.

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Dec 25, 2025

@durgajagadeesh Buddy Build have test failures. Can you check them?
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1010273&view=logs&j=bac295d9-f2e0-5165-e63e-e76f383e1a27&t=859205e3-cba0-55b5-b3f1-35d1c4f611a6

Hi @sandeepkarambelkar, I was working on this package to resolve test failures. Thank you.

I was found this issue with libpkgconf version.

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Dec 26, 2025

@durgajagadeesh Buddy Build have test failures. Can you check them?
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1010273&view=logs&j=bac295d9-f2e0-5165-e63e-e76f383e1a27&t=859205e3-cba0-55b5-b3f1-35d1c4f611a6

Hi @sandeepkarambelkar, I was working on this package to resolve test failures. Thank you.

I was found this issue with libpkgconf version.

The tests are failing during the Upgrade because of a version mismatch in libpkgconf.

The upstream Perl module PkgConfig::LibPkgConf 0.11 was designed for libpkgconf 1.x, but our CBL-mariner uses libpkgconf 2.x.

The tests in PkgConfig-LibPkgConf-0.11.tar.gz assume libpkgconf 1.x ordering semantics, while libpkgconf 2.x (used in CBL-mariner) behaves differently.

libpkgconf 2.x returns paths in a different order compared to libpkgconf 1.x,

With libpkgconf 2.x (2.0.2 on Mariner), the internal ordering has changed for:

search paths
lib dirs
include dirs
path attributes

`Tests in t/client.t hardcode the expected ordering, so the module’s output does not match anymore.

Example mismatch(debug message from log):

Failed test at t/client.t line 220.:

time="2025-12-25T06:43:13Z" level=debug msg="        #     Structures begin differing at:"

time="2025-12-25T06:43:13Z" level=debug msg="        #          $got->[0] = '/tmp/LzQo2YxNiG/bar'"

time="2025-12-25T06:43:13Z" level=debug msg="        #     $expected->[0] = '/tmp/LzQo2YxNiG/foo'"

Failed test at t/client.t line 223.:

time="2025-12-25T06:43:13Z" level=debug msg="        #     Structures begin differing at:"

time="2025-12-25T06:43:13Z" level=debug msg="        #          $got->[0] = '/tmp/LzQo2YxNiG/formers'"

time="2025-12-25T06:43:13Z" level=debug msg="        #     $expected->[0] = '/tmp/LzQo2YxNiG/trans'"
`

Note: this version change only impacts tests and doesn't impact functionality of the RPM.

@durgajagadeesh
Copy link
Contributor Author

durgajagadeesh commented Dec 26, 2025

@durgajagadeesh Buddy Build have test failures. Can you check them?
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1010273&view=logs&j=bac295d9-f2e0-5165-e63e-e76f383e1a27&t=859205e3-cba0-55b5-b3f1-35d1c4f611a6

Hi @sandeepkarambelkar, I was working on this package to resolve test failures. Thank you.

I was found this issue with libpkgconf version.

The tests are failing during the Upgrade because of a version mismatch in libpkgconf.

The upstream Perl module PkgConfig::LibPkgConf 0.11 was designed for libpkgconf 1.x, but our CBL-mariner uses libpkgconf 2.x.

The tests in PkgConfig-LibPkgConf-0.11.tar.gz assume libpkgconf 1.x ordering semantics, while libpkgconf 2.x (used in CBL-mariner) behaves differently.

libpkgconf 2.x returns paths in a different order compared to libpkgconf 1.x,

With libpkgconf 2.x (2.0.2 on Mariner), the internal ordering has changed for:

search paths lib dirs include dirs path attributes

`Tests in t/client.t hardcode the expected ordering, so the module’s output does not match anymore.

Example mismatch(debug message from log):

Failed test at t/client.t line 220.:

time="2025-12-25T06:43:13Z" level=debug msg="        #     Structures begin differing at:"

time="2025-12-25T06:43:13Z" level=debug msg="        #          $got->[0] = '/tmp/LzQo2YxNiG/bar'"

time="2025-12-25T06:43:13Z" level=debug msg="        #     $expected->[0] = '/tmp/LzQo2YxNiG/foo'"

Failed test at t/client.t line 223.:

time="2025-12-25T06:43:13Z" level=debug msg="        #     Structures begin differing at:"

time="2025-12-25T06:43:13Z" level=debug msg="        #          $got->[0] = '/tmp/LzQo2YxNiG/formers'"

time="2025-12-25T06:43:13Z" level=debug msg="        #     $expected->[0] = '/tmp/LzQo2YxNiG/trans'" `

Note: this version change only impacts tests and doesn't impact functionality of the RPM.

image

@durgajagadeesh
Copy link
Contributor Author

Hi @sandeepkarambelkar, I have disabled the only failing test because of the Tests in t/client.t hardcode the expected ordering, so the module’s output does not match anymore.
The build is completed successfully after this change as shown in below.
image

Note: these changes only impacts tests and doesn't impact functionality of the RPM.
Please let me know if these changes are acceptable.
-Thank you!

@sandeepkarambelkar
Copy link
Contributor

Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
%endif
Requires: perl(Carp)
Requires: libpkgconf > 2.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we provide libpkgconf 2.1.0 version. Our version is 2.0.2
https://packages.microsoft.com/azurelinux/3.0/prod/base/x86_64/Packages/l/libpkgconf-2.0.2-1.azl3.x86_64.rpm

Can you correct the version and test the build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sandeepkarambelkar, I have incorporated my changes and tested to the resolve this error.
Please let me know if there is any changes has to be update.
-Thank you!

Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy Build install test failed with error -

Installing perl-PkgConfig-LibPkgConf
Loaded plugin: tdnfrepogpgcheck

  1. nothing provides libpkgconf > 2.1.0 needed by perl-PkgConfig-LibPkgConf-0.11-24.azl3.x86_64

Need to compile with 2.0.2 version

@durgajagadeesh
Copy link
Contributor Author

Buddy Build install test failed with error -

Installing perl-PkgConfig-LibPkgConf Loaded plugin: tdnfrepogpgcheck

  1. nothing provides libpkgconf > 2.1.0 needed by perl-PkgConfig-LibPkgConf-0.11-24.azl3.x86_64

Need to compile with 2.0.2 version

Hi @sandeepkarambelkar, I have incorporated my changes to the resolve this error.
Please let me know if there is any changes has to be update.
a) Build summary:
image

b) Installation:
image

-Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants